search

sonic-net / sonic-buildimage

Scripts which perform an installable binary image build for SONiC
Other
711 stars 1.36k forks source link

show sflow interface command is not working for 2.5G speed #14831

Open rajneeshaec opened 1 year ago

rajneeshaec commented 1 year ago

Description

show sflow interface command is not working for 2.5G port

Describe the results you received:

Show sflow interface command support is not present for 2.5 G speed Please find "show sflow interface" output from APP_DB.

define SFLOW_SAMPLE_RATE_VALUE_400G "400000"

define SFLOW_SAMPLE_RATE_VALUE_200G "200000"

define SFLOW_SAMPLE_RATE_VALUE_100G "100000"

define SFLOW_SAMPLE_RATE_VALUE_50G "50000"

define SFLOW_SAMPLE_RATE_VALUE_40G "40000"

define SFLOW_SAMPLE_RATE_VALUE_25G "25000"

define SFLOW_SAMPLE_RATE_VALUE_10G "10000"

define SFLOW_SAMPLE_RATE_VALUE_1G "1000"

define SFLOW_ERROR_SPEED_STR "error"

neethajohn commented 1 year ago

@rajneeshaec , can you please describe your use case?

jeff-yin commented 1 year ago

Please assign to @Gokulnath-Raja, who is working on sFlow at Dell.

Gokulnath-Raja commented 1 year ago

@rajneeshaec , please provide which platform do we need to provide support for 2.5G? Please share the use case.

rajkumar38 commented 1 year ago

@rajneeshaec , please provide which platform do we need to provide support for 2.5G? Please share the use case.

We have deployment use-case for management switch with 2.5G ports. Platform is marvell-arm64.

jeff-yin commented 1 year ago

@rajneeshaec @rajkumar38 -- we (Dell) don't have 2.5G platforms to be able to validate potential fix(es) for this issue. I recommend that you take up this issue and submit a PR to update the code to account for 2.5G and any other speeds you might need for your platforms. @Gokulnath-Raja and the rest of the community can help and provide review feedback. If needed you can reach out to InMon too, if any support is needed from the backend application.

For the time being I will unassign Dell from the issue. Please have someone from Marvell take it up so that they would be able to test the fix.

rajkumar38 commented 1 year ago

@rajneeshaec @rajkumar38 -- we (Dell) don't have 2.5G platforms to be able to validate potential fix(es) for this issue. I recommend that you take up this issue and submit a PR to update the code to account for 2.5G and any other speeds you might need for your platforms. @Gokulnath-Raja and the rest of the community can help and provide review feedback. If needed you can reach out to InMon too, if any support is needed from the backend application.

For the time being I will unassign Dell from the issue. Please have someone from Marvell take it up so that they would be able to test the fix.

Sure. We will raise PR.