Support SONIC cli commands for QoS/MMU configuration/stats for multi-asic

[vmittal-msft]

Description

Need to enhance SONIC cli commands for QoS/MMU configuration/stats for chassis. Some of the commands support '-n asic0/asic1' but some don't.

mmuconfig -l (show buffer) ecnconfig -l (show ecn) show buffer_pool watermark/persistent-watermark Show headroom-pool watermark/persistent-watermark show pfc asymmetric/counters/priority show pfcwd stats/config Show priority-group drop/persistent-watermark/watermark Show queue counters/persistent-watermark/watermark

Steps to reproduce the issue:

1. 2. 3.

Describe the results you received:

Describe the results you expected:

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

QoS-MMU commands output.txt

Additional information you deem important (e.g. issue happens only occasionally):

[arlakshm]

This is feature ask to support all the qos commands natively for multi asic linecards.

[kenneth-arista]

@vmittal-msft Arista is working on this. Please assign to me.

[vmittal-msft]

@kenneth-arista @bktsim-arista please update PRs in description section for better tracking ? Also, are we expecting more PRs for pfc and pfcwd changes ?

[rdjeric-arista]

@vmittal-msft

https://github.com/sonic-net/sonic-utilities/pull/3057 Places the PFC commands in a class (no namespace changes in this PR; such changes will come in a later PR)

https://github.com/sonic-net/sonic-utilities/pull/3058 show priority-group drop counters

https://github.com/sonic-net/sonic-utilities/pull/3059 dropstat -c show show dropcounters counts

https://github.com/sonic-net/sonic-utilities/pull/3060 show buffer_pool watermark/persistent-watermark show headroom-pool watermark/persistent-watermark show priority-group persistent-watermark/watermark show queue persistent-watermark/watermark

https://github.com/sonic-net/sonic-utilities/pull/3061 mmuconfig -l

https://github.com/sonic-net/sonic-utilities/pull/3062 ecnconfig -l config ecn show ecn

[kenneth-arista]

@vmittal-msft with https://github.com/sonic-net/sonic-utilities/pull/3060 merging recently, I believe this issue is now complete. Please confirm and then close this issue.

[arista-hpandya]

Queuestat (https://github.com/sonic-net/sonic-utilities/pull/3554) is the last PR required to close this issue.

For future maintenance here is a checklist I have prepared to make sure we are following the best practices when adding multi-asic support to SONiC CLI. Sharing it here for the benefit of the community: https://gist.github.com/arista-hpandya/716e955a4b896d6e6343bf19516804f2

[vmittal-msft]

Thanks for help @arista-hpandya @bktsim-arista @rdjeric-arista @kenneth-arista and arista team. Please double check one more time to make sure we are not missing any request. If not, please go ahead and close.

[arista-hpandya]

Hi @vmittal-msft, yes I have cross-checked that we can close the issue.

PS: I don't have the permission to close the issue so requesting a moderator to close this.

[kenneth-arista]

Hi @vmittal-msft, yes I have cross-checked that we can close the issue.

PS: I don't have the permission to close the issue so requesting a moderator to close this.

Echoing @arista-hpandya's comment, @vmittal-msft please close this issue as complete at your convenience.

[vmittal-msft]

Thanks Arista team for help.