search

sonic-net / sonic-buildimage

Scripts which perform an installable binary image build for SONiC
Other
736 stars 1.42k forks source link

[dhcpv6_relay] [counters] counters doesn't rise on tagged Physical Interface #17377

Open vivekrnv opened 11 months ago

vivekrnv commented 11 months ago

Description

With this new ability https://github.com/sonic-net/sonic-dhcp-relay/pull/43 to see dhcp_relay counters in Physical interfaces in addition to L3 Vlan interface, I can't see Reply and Advertise counters rising on Physical interfaces connected to dhcp client, But I can see it on L3 Vlan interace.

The sonic-mgmt test covers this scenario, but for untagged interfaces.

root@qa-eth-vt01-5-2700a0:/home/admin# show dhcp_relay ipv6 counters 
       Message Type    Ethernet0(RX)
-------------------  ---------------
          Advertise                0
            Confirm                0
            Decline                0
Information-Request                0
          Malformed                0
             Rebind                0
        Reconfigure                0
      Relay-Forward                0
        Relay-Reply                2
            Release                0
              Renew                0
              Reply                0
            Request                0
            Solicit                0
            Unknown                0

       Message Type    Ethernet0(TX)
-------------------  ---------------
          Advertise                0
            Confirm                0
            Decline                0
Information-Request                0
          Malformed                0
             Rebind                0
        Reconfigure                0
      Relay-Forward                2
        Relay-Reply                0
            Release                0
              Renew                0
              Reply                0
            Request                0
            Solicit                0
            Unknown                0

       Message Type    Ethernet4(RX)
-------------------  ---------------
          Advertise                0
            Confirm                0
            Decline                0
Information-Request                0
          Malformed                0
             Rebind                0
        Reconfigure                0
      Relay-Forward                0
        Relay-Reply                0
            Release                0
              Renew                0
              Reply                0
            Request                1
            Solicit                1
            Unknown                0

       Message Type    Ethernet4(TX)
-------------------  ---------------
            Unknown                0
            Solicit                0
          Advertise                0
            Request                0
            Confirm                0
              Renew                0
             Rebind                0
              Reply                0
            Release                0
            Decline                0
        Reconfigure                0
Information-Request                0
      Relay-Forward                0
        Relay-Reply                0
          Malformed                0

       Message Type    Vlan2024(RX)
-------------------  --------------
          Advertise               0
            Confirm               0
            Decline               0
Information-Request               0
          Malformed               0
             Rebind               0
        Reconfigure               0
      Relay-Forward               0
        Relay-Reply               2
            Release               0
              Renew               0
              Reply               0
            Request               1
            Solicit               1
            Unknown               0

       Message Type    Vlan2024(TX)
-------------------  --------------
          Advertise               1
            Confirm               0
            Decline               0
Information-Request               0
          Malformed               0
             Rebind               0
        Reconfigure               0
      Relay-Forward               2
        Relay-Reply               0
            Release               0
              Renew               0
              Reply               1
            Request               0
            Solicit               0
            Unknown               0

Setup description

dhcp client -> Ethernet4 -> Vlan2024 -> Ethernet0 -> dhcp server

Steps to reproduce

1) Configure interfaces to IPv6 DHCP server and Client 2) Configure IPv6 dhcp_ 3) Request IPv6 address from ipv6 client 4) check IPv6 dhcp relay counters

vivekrnv commented 11 months ago

@yaqiangz @yxieca @kellyyeh, Please check

yaqiangz commented 11 months ago

@vivekrnv I wonder whether we can confirm the advertise and reply packets is actually send to client in scenario you mentioned?

vivekrnv commented 11 months ago

yes, it is sent. Client receive address, and we can see these counters rised on Vlan Interface

yaqiangz commented 11 months ago

yes, it is sent. Client receive address, and we can see these counters rised on Vlan Interface

From dump file you shared, seems this is a ToRRouter? Could you share more details about this use case like why tagged is needed to let me fully understand this scenario?

prgeor commented 11 months ago

@vivekrnv please confirm this is a valid scenario

vivekrnv commented 11 months ago

yes, it is sent. Client receive address, and we can see these counters rised on Vlan Interface

From dump file you shared, seems this is a ToRRouter? Could you share more details about this use case like why tagged is needed to let me fully understand this scenario?

@yaqiangz , good point. Seems trunk vlan is not a general use case. Keeping the issue as open, as documentation