search

sonic-net / sonic-buildimage

Scripts which perform an installable binary image build for SONiC
Other
734 stars 1.41k forks source link

QoS buffer information missing on Celestica DX010 #18489

Open mbze430 opened 6 months ago

mbze430 commented 6 months ago 
 ---------------------------------------------------
 BUG REPORT INFORMATION
 ---------------------------------------------------
 Use the commands below to provide key information from your environment:
 You do NOT have to include this information if this is a FEATURE REQUEST

-->

Description

Steps to reproduce the issue:

  1. sudo config qos reload.

Describe the results you received:

Operation not completed successfully, please save and reload configuration. Buffer definition template not found at /usr/share/sonic/device/x86_64-cel_seastone-r0/Seastone-DX010/buffers.json.j2

Describe the results you expected:

to load the qos

Output of show version:

SONiC Software Version: SONiC.202305.505816-7b32c39cc SONiC OS Version: 11 Distribution: Debian 11.8 Kernel: 5.10.0-23-2-amd64 Build commit: 7b32c39cc Build date: Sat Mar 23 13:42:14 UTC 2024 Built by: AzDevOps@vmss-soni003BY6

Platform: x86_64-cel_seastone-r0 HwSKU: Seastone-DX010 ASIC: broadcom ASIC Count: 1 Serial Number: DX010B2F108423LK100045 Model Number: R0872-F0010-01 Hardware Revision: N/A Uptime: 18:40:30 up 4 days, 40 min, 1 user, load average: 1.53, 1.43, 1.58 Date: Wed 27 Mar 2024 18:40:30

Docker images: REPOSITORY TAG IMAGE ID SIZE docker-gbsyncd-broncos 202305.505816-7b32c39cc 291d5fd0b380 350MB docker-gbsyncd-broncos latest 291d5fd0b380 350MB docker-gbsyncd-credo 202305.505816-7b32c39cc 6a015c2e8a0c 322MB docker-gbsyncd-credo latest 6a015c2e8a0c 322MB docker-syncd-brcm 202305.505816-7b32c39cc 56c3482f46f9 674MB docker-syncd-brcm latest 56c3482f46f9 674MB docker-orchagent 202305.505816-7b32c39cc 356f313d7a58 330MB docker-orchagent latest 356f313d7a58 330MB docker-fpm-frr 202305.505816-7b32c39cc 92259e80be71 349MB docker-fpm-frr latest 92259e80be71 349MB docker-nat 202305.505816-7b32c39cc 454193a830e2 321MB docker-nat latest 454193a830e2 321MB docker-sflow 202305.505816-7b32c39cc d881c9329a4b 319MB docker-sflow latest d881c9329a4b 319MB docker-teamd 202305.505816-7b32c39cc cc4307f86be4 318MB docker-teamd latest cc4307f86be4 318MB docker-macsec latest 2f85259a9c97 320MB docker-dhcp-relay latest 5d35918adec6 308MB docker-eventd 202305.505816-7b32c39cc 2c77467fe9e8 300MB docker-eventd latest 2c77467fe9e8 300MB docker-snmp 202305.505816-7b32c39cc b9b71b755043 339MB docker-snmp latest b9b71b755043 339MB docker-sonic-telemetry 202305.505816-7b32c39cc 1bfdf24f6c0e 387MB docker-sonic-telemetry latest 1bfdf24f6c0e 387MB docker-platform-monitor 202305.505816-7b32c39cc b5cd1d0ad916 422MB docker-platform-monitor latest b5cd1d0ad916 422MB docker-lldp 202305.505816-7b32c39cc 12a9d413addc 343MB docker-lldp latest 12a9d413addc 343MB docker-database 202305.505816-7b32c39cc ca3c523eb529 300MB docker-database latest ca3c523eb529 300MB docker-mux 202305.505816-7b32c39cc 4df83002bc21 349MB docker-mux latest 4df83002bc21 349MB docker-router-advertiser 202305.505816-7b32c39cc 8bc42f61653d 300MB docker-router-advertiser latest 8bc42f61653d 300MB docker-sonic-mgmt-framework 202305.505816-7b32c39cc adf6625131b1 414MB docker-sonic-mgmt-framework latest adf6625131b1 414MB

judyjoseph commented 6 months ago

Looks like the qos buffer profile is missing ? Can you check if this is supported platform @skannan-sonic @qnos thanks.

mbze430 commented 6 months ago

Some what of a finding. in the folder /usr/share/sonic/device/x86_64-cel_seastone-r0/. There are Celestica-DX010-C32 and Celestica-DX010. Maybe Celestica-DX010-C32 is a different revision? There is also a folder Seastone-DX010... so I don't know what's going on. But the necessary files are in the combination of Celesitca-DX010-C32 and Seastone-DX010.

Maybe there is a need of a "clean-up"?

qnos commented 6 months ago

Historical issue.

@mbze430 A workaround:

sudo cp /usr/share/sonic/device/x86_64-cel_seastone-r0/Celestica-DX010-C32/*.j2 /usr/share/sonic/device/x86_64-cel_seastone-r0/Seastone-DX010/
sudo cp /usr/share/sonic/device/x86_64-cel_seastone-r0/Celestica-DX010-C32/pg_profile_lookup.ini /usr/share/sonic/device/x86_64-cel_seastone-r0/Seastone-DX010/
sudo rm /usr/share/sonic/device/x86_64-cel_seastone-r0/Seastone-DX010/sai.profile.j2

I will add a copy into Seastone-DX010 sku recently.

mbze430 commented 6 months ago

If this is a historical issue, why hasn't it been addressed till now?

mbze430 commented 6 months ago

just had some time to upgrade the DX010 firmware. Still no QoS

SONiC Software Version: SONiC.202305.524815-d56e64b16 SONiC OS Version: 11 Distribution: Debian 11.8 Kernel: 5.10.0-23-2-amd64 Build commit: d56e64b16 Build date: Wed Apr 17 13:56:26 UTC 2024 Built by: AzDevOps@vmss-soni003HTG

Platform: x86_64-cel_seastone-r0 HwSKU: Seastone-DX010 ASIC: broadcom ASIC Count: 1 Serial Number: DX010B2F108423LK100045 Model Number: R0872-F0010-01 Hardware Revision: N/A Uptime: 22:46:41 up 3 min, 1 user, load average: 1.74, 1.54, 0.67 Date: Wed 17 Apr 2024 22:46:41

Docker images: REPOSITORY TAG IMAGE ID SIZE docker-gbsyncd-broncos 202305.524815-d56e64b16 ba53924125f9 350MB docker-gbsyncd-broncos latest ba53924125f9 350MB docker-gbsyncd-credo 202305.524815-d56e64b16 f3878cf031b6 322MB docker-gbsyncd-credo latest f3878cf031b6 322MB docker-syncd-brcm 202305.524815-d56e64b16 ca584abdf331 674MB docker-syncd-brcm latest ca584abdf331 674MB docker-orchagent 202305.524815-d56e64b16 3bae22436950 330MB docker-orchagent latest 3bae22436950 330MB docker-fpm-frr 202305.524815-d56e64b16 f323799a3d84 349MB docker-fpm-frr latest f323799a3d84 349MB docker-nat 202305.524815-d56e64b16 c11067845bb6 321MB docker-nat latest c11067845bb6 321MB docker-sflow 202305.524815-d56e64b16 78956fbd024c 319MB docker-sflow latest 78956fbd024c 319MB docker-teamd 202305.524815-d56e64b16 b776b5b38a9c 318MB docker-teamd latest b776b5b38a9c 318MB docker-macsec latest 00a78a1b2c37 320MB docker-eventd 202305.524815-d56e64b16 b252b0136d72 300MB docker-eventd latest b252b0136d72 300MB docker-dhcp-relay latest 57e700b5c83a 308MB docker-snmp 202305.524815-d56e64b16 d5baedba17bc 339MB docker-snmp latest d5baedba17bc 339MB docker-sonic-telemetry 202305.524815-d56e64b16 27315ce3e2e4 387MB docker-sonic-telemetry latest 27315ce3e2e4 387MB docker-platform-monitor 202305.524815-d56e64b16 7ff91700d937 422MB docker-platform-monitor latest 7ff91700d937 422MB docker-router-advertiser 202305.524815-d56e64b16 ccbe7a040ce2 300MB docker-router-advertiser latest ccbe7a040ce2 300MB docker-lldp 202305.524815-d56e64b16 266fabe672fe 343MB docker-lldp latest 266fabe672fe 343MB docker-mux 202305.524815-d56e64b16 6b58fc4c216a 349MB docker-mux latest 6b58fc4c216a 349MB docker-database 202305.524815-d56e64b16 f25cf02970b3 300MB docker-database latest f25cf02970b3 300MB docker-sonic-mgmt-framework 202305.524815-d56e64b16 7e9096b3f772 414MB docker-sonic-mgmt-framework latest 7e9096b3f772 414MB

sudo config qos reload Operation not completed successfully, please save and reload configuration. Buffer definition template not found at /usr/share/sonic/device/x86_64-cel_seastone-r0/Seastone-DX010/buffers.json.j2 admin@sonic:~/temp$

mbze430 commented 6 months ago

tonight I tried the suggested fix to copy the files over. it completely crashed the switch. after copying the files I rebooted the switch and the swss service will not start. I even copied my original config_db.json and still won't boot correctly. I have to reload the entire thing again. This is version 202311

rm /etc/sonic/config_db.json sudo config-setup factory

that didn't help either.

qnos commented 6 months ago

sudo rm /usr/share/sonic/device/x86_64-cel_seastone-r0/Seastone-DX010/sai.profile.j2

Update the commands.

qnos commented 6 months ago

sudo rm /usr/share/sonic/device/x86_64-cel_seastone-r0/Seastone-DX010/sai.profile.j2

tonight I tried the suggested fix to copy the files over. it completely crashed the switch. after copying the files I rebooted the switch and the swss service will not start. I even copied my original config_db.json and still won't boot correctly. I have to reload the entire thing again. This is version 202311

rm /etc/sonic/config_db.json sudo config-setup factory

that didn't help either.

Try remove the sai.profile.j2 file, the old command introduced a sai.profile j2 template file, which would cause the profile not found issue.

sudo rm /usr/share/sonic/device/x86_64-cel_seastone-r0/Seastone-DX010/sai.profile.j2
mbze430 commented 5 months ago

Okay that seems to have gotten things running. Will this be implemented to the master and all the other builds?

qnos commented 5 months ago

Okay that seems to have gotten things running. Will this be implemented to the master and all the other builds?

Already raised PR #18781, for master, 202305 and 202211.

mbze430 commented 4 months ago

as of 6/6/24 version SONiC.202311.564467-43bcca75f this PR still have not been merged to 202311.

mbze430 commented 4 months ago

@qnos anyway you can raise the PR and merge it to 202311 as well?