search

sonic-net / sonic-buildimage

Scripts which perform an installable binary image build for SONiC
Other
723 stars 1.38k forks source link

Breakout not working on Dell S5248F #19995

Open tomvil opened 2 weeks ago

tomvil commented 2 weeks ago

Description

Breakout should be supported on DELL S5248F but it is not working.

Steps to reproduce the issue:

  1. Run show interfaces breakout
  2. Get error: Invalid JSON file format('/usr/share/sonic/device/x86_64-dellemc_s5248f_c3538-r0/DellEMC-S5248f-P-25G/port_config.ini')

Describe the results you received:

Got an Invalid JSON file format('/usr/share/sonic/device/x86_64-dellemc_s5248f_c3538-r0/DellEMC-S5248f-P-25G/port_config.ini') error

Describe the results you expected:

Display breakout information

Output of show version:


SONiC Software Version: SONiC.202405.0-dirty-20240823.094757
SONiC OS Version: 12
Distribution: Debian 12.6
Kernel: 6.1.0-11-2-amd64
Build commit: d004a4993
Build date: Fri Aug 23 07:50:22 UTC 2024

Platform: x86_64-dellemc_s5248f_c3538-r0
HwSKU: DellEMC-S5248f-P-25G
ASIC: broadcom
ASIC Count: 1
Serial Number: N/A
Model Number: N/A
Hardware Revision: N/A
Uptime: 08:47:52 up 10 min,  1 user,  load average: 1.78, 2.00, 1.30
Date: Fri 23 Aug 2024 08:47:52
tomvil commented 2 weeks ago

Just noticed that the device doesn't have platform.json and etc included. So probably it's support is not implemented yet? Any plans to do so?

gechiang commented 2 weeks ago

@jeff-yin please help. this is DELL platform. Thanks!

jeff-yin commented 2 weeks ago

We're working on updating the s52xx platforms since their initial contribution to the Sonic project. One such activity is converting them to PDDF. (https://github.com/sonic-net/sonic-buildimage/pull/18849) We will also work on implementing platform.json to enable dynamic breakout.

tomvil commented 1 week ago

Thank you for the information @jeff-yin. Should I close this issue or leave it for tracking?

jeff-yin commented 1 week ago

Please leave it open, thanks. @arunlk-dell will work on it.

jeff-yin commented 1 week ago

@jeff-yin please help. this is DELL platform.

Thanks!

@gechiang I can't assign the issue to people. Can you grant me permission? I'm a dev engineering manager at Dell, so it would be helpful if I could assign issues to our staff. Thanks!

gechiang commented 1 week ago

@lguohan , @yxieca , Can you grant @jeff-yin the needed permission to assign issues to his staff Eng? Thanks!