sonic-net / sonic-buildimage

Scripts which perform an installable binary image build for SONiC
Other
729 stars 1.39k forks source link

[fast-reboot] Implement cleanup path for delaying counters #20270

Open stepanblyschak opened 2 weeks ago

stepanblyschak commented 2 weeks ago

Description

Steps to reproduce the issue:

  1. Make fast-reboot fail after counters are delayed
  2. Counters are delaying in config_db after a failure occured

Describe the results you received:

fast-reboot does not cleanup counters delay.

Describe the results you expected:

fast-reboot should cleanup delay.

Output of show version:

SONiC Software Version: SONiC.202405_RC.16-8c5f02079_Internal
SONiC OS Version: 12
Distribution: Debian 12.6
Kernel: 6.1.0-11-2-amd64
Build commit: 046c106f7
Build date: Wed Aug 28 10:57:10 UTC 2024
Built by: sw-r2d2-bot@r-build-sonic-ci03-242

Platform: x86_64-mlnx_msn4600c-r0
HwSKU: Mellanox-SN4600C-C64
ASIC: mellanox
ASIC Count: 1
Serial Number: MT2138X00017
Model Number: MSN4600-CS2FO
Hardware Revision: AB
Uptime: 12:08:22 up 7 min,  1 user,  load average: 0.23, 0.48, 0.32
Date: Mon 16 Sep 2024 12:08:22

Docker images:
REPOSITORY                                            TAG                               IMAGE ID       SIZE
docker-orchagent                                      202405_RC.16-8c5f02079_Internal   1701d14eddac   356MB
docker-orchagent                                      latest                            1701d14eddac   356MB
docker-teamd                                          202405_RC.16-8c5f02079_Internal   08c4d82a8f06   343MB
docker-teamd                                          latest                            08c4d82a8f06   343MB
docker-fpm-frr                                        202405_RC.16-8c5f02079_Internal   2248b30f2ea5   374MB
docker-fpm-frr                                        latest                            2248b30f2ea5   374MB
docker-nat                                            202405_RC.16-8c5f02079_Internal   7bf1a7d327e7   345MB
docker-nat                                            latest                            7bf1a7d327e7   345MB
docker-sflow                                          202405_RC.16-8c5f02079_Internal   56ca25705952   344MB
docker-sflow                                          latest                            56ca25705952   344MB
docker-syncd-mlnx                                     202405_RC.16-8c5f02079_Internal   779f8eb1e8fd   847MB
docker-syncd-mlnx                                     latest                            779f8eb1e8fd   847MB
docker-dhcp-relay                                     latest                            35daad25a889   324MB
docker-snmp                                           202405_RC.16-8c5f02079_Internal   aa84c219a537   354MB
docker-snmp                                           latest                            aa84c219a537   354MB
docker-macsec                                         latest                            8f75e83df31b   345MB
docker-sonic-mgmt-framework                           202405_RC.16-8c5f02079_Internal   5c42b831d74f   400MB
docker-sonic-mgmt-framework                           latest                            5c42b831d74f   400MB
docker-platform-monitor                               202405_RC.16-8c5f02079_Internal   62f29f25dbda   441MB
docker-platform-monitor                               latest                            62f29f25dbda   441MB
docker-router-advertiser                              202405_RC.16-8c5f02079_Internal   63b83388805f   314MB
docker-router-advertiser                              latest                            63b83388805f   314MB
docker-lldp                                           202405_RC.16-8c5f02079_Internal   65e9705b953b   360MB
docker-lldp                                           latest                            65e9705b953b   360MB
docker-database                                       202405_RC.16-8c5f02079_Internal   cd334db3d79c   323MB
docker-database                                       latest                            cd334db3d79c   323MB
docker-sonic-gnmi                                     202405_RC.16-8c5f02079_Internal   1c4381c1963e   398MB
docker-sonic-gnmi                                     latest                            1c4381c1963e   398MB
docker-mux                                            202405_RC.16-8c5f02079_Internal   de1d033aac20   366MB
docker-mux                                            latest                            de1d033aac20   366MB
docker-eventd                                         202405_RC.16-8c5f02079_Internal   4d98eefa17b3   314MB
docker-eventd                                         latest                            4d98eefa17b3   314MB

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

bingwang-ms commented 1 week ago

Discussed in issue triage meeting, issue assigned to @stepanblyschak .