search

sonic-net / sonic-buildimage

Scripts which perform an installable binary image build for SONiC
Other
719 stars 1.38k forks source link

[MGMT] Request: Get yang models from the yang-models dir to sonic-mgmt-common instead of duplicating a subset of them there #6025

Open chaichairiko opened 3 years ago

anshuv-mfst commented 3 years ago

Please provide more information on the enhancement request.

zhangyanzhao commented 2 years ago

@chaichairiko can you please provide more info on your request? Thanks.

zhangyanzhao commented 2 years ago

@venkatmahalingam will summarize the request. Thanks.

venkatmahalingam commented 2 years ago

Request: Get yang models from the yang-models dir to sonic-mgmt-common instead of duplicating a subset of them there

This is the long-term goal but currently, the plan is to keep separate YANG models in mgmt-framework as it provides additional capabilities that are tightly coupled with CVL i.e custom validation.

There is a plan to follow Guohan's proposal to templatize the YANG models but no ETA yet.

zhangyanzhao commented 2 years ago

Known limitation.

zhangyanzhao commented 2 years ago

@praveen-li will share a PR which we think can fix this issue. Need double check with sub-group, @chaichairiko can you please joi n next YANG subgroup meeting to discuss? Thanks.

praveen-li commented 2 years ago

Look at: https://github.com/Azure/sonic-buildimage/pull/8880. It generates 2 yang models based on templates. Let us know the exact concern if any other. @chaichairiko chaichairiko

zhangyanzhao commented 2 years ago

Not YANG model issue, general assets management issue.

zhangyanzhao commented 2 years ago

venkatmahalingam will talk to DELL team on the plan.