[sflow] Invalid sflow interface admin state keyword returned

[Hedgehog-Guru]

Description

"show sflow interface" output contain "up" and "down" keywords for Admin State, but according to HLD it should be "Enabled" / "Disabled".

Steps to reproduce the issue:

1. Enable sflow globally

   config feature state sflow enabled
   config sflow enable

2. Disable sflow for one of interfaces just to check state in the following output

   config sflow interface disable Ethernet4

3. Check output the per interface sflow state

   show sflow interface 

Describe the results you received:

+-------------+---------------+-----------------+
| Interface   | Admin State   | Sampling Rate   |
+=============+===============+=================+
| Ethernet0   | up            | error           |
+-------------+---------------+-----------------+
| Ethernet4   | down          | error           |
+-------------+---------------+-----------------+
<-- skip -->

Describe the results you expected:

Enabled/Disabled instead of up/down

Output of show version:

SONiC Software Version: SONiC.SONIC.202012.10-d26a4af_Internal
Distribution: Debian 10.7
Kernel: 4.19.0-9-2-amd64
Build commit: d26a4aff
Build date: Thu Feb  4 15:28:36 UTC 2021
Built by: sw-r2d2-bot@r-build-sonic-ci02

Platform: x86_64-mlnx_msn3700-r0
HwSKU: ACS-MSN3700
ASIC: mellanox
ASIC Count: 1
Serial Number: MT1852X03965
Uptime: 16:34:11 up 55 min,  1 user,  load average: 1.04, 0.85, 0.90

Additional information you deem important (e.g. issue happens only occasionally):

sonic_dump_qa-anconda-test10_20210216_163433.tar.gz

[prsunny]

"up"/"down" is widely being used in Sonic. Could you update the HLD?

[jeff-yin]

@GarrickHe can you push an update to the HLD to change the "admin state" to up/down in order to reflect the actual operation of the code? https://github.com/Azure/SONiC/blob/master/doc/sflow/sflow_hld.md

[anshuv-mfst]

Issue Triage 2/17: Dell team to provide input on the issue, thanks!

[GarrickHe]

PR: https://github.com/Azure/SONiC/pull/755