search

sonic-net / sonic-buildimage

Scripts which perform an installable binary image build for SONiC
Other
736 stars 1.42k forks source link

[test_decap] [Broadcom] test_decap fails due to DSCP Uniform mode issue with IPinIP tunnel #8525

Closed tjchadaga closed 3 years ago

tjchadaga commented 3 years ago

Description

IPinIP tunnels programmed with DSCP Uniform mode in ASIC-DB are not taking effect on any of the Broadcom XGS platforms (except TD3). The test failure is seen for IPv4 & IPv6 tunnels

Steps to reproduce the issue:

  1. Run decap/test_decap.py on TH, TH2, TH3 or TD2 platform

Describe the results you received:

test_decap fails due to DSCP field from outer IP header not being retained

Sent Packet: 18:36:54.437349 ca:ed:30:a2:58:1c > c8:f7:50:ed:7c:c1, ethertype IPv4 (0x0800), length 77: (tos 0xc, ttl 64, id 1, offset 0, flags [none], proto IPIP (4), length 63) 1.1.1.1 > 10.1.0.32: (tos 0x0, ttl 64, id 1, offset 0, flags [none], proto Options (0), length 43) 1.1.1.1 > 1.0.0.0: ip-proto-0 23 0x0000: c8f7 50ed 7cc1 caed 30a2 581c 0800 450c ..P.|...0.X...E. 0x0010: 003f 0001 0000 4004 6e8c 0101 0101 0a01 .?....@.n....... 0x0020: 0020 4500 002b 0001 0000 4000 77d1 0101 ..E..+....@.w... 0x0030: 0101 0100 0000 536f 6e69 6320 6465 6361 ......Sonic.deca 0x0040: 7020 6272 6f6b 656e 2074 6573 74 p.broken.test

Received Packet after decap: 18:38:15.135576 c8:f7:50:ed:7c:c1 > 52:54:00:80:ca:b7, ethertype IPv4 (0x0800), length 60: (tos 0x0, ttl 63, id 1, offset 0, flags [none], proto Options (0), length 43) 1.1.1.1 > 1.0.0.0: ip-proto-0 23 0x0000: 5254 0080 cab7 c8f7 50ed 7cc1 0800 4500 RT......P.|...E. 0x0010: 002b 0001 0000 3f00 78d1 0101 0101 0100 .+....?.x....... 0x0020: 0000 536f 6e69 6320 6465 6361 7020 6272 ..Sonic.decap.br 0x0030: 6f6b 656e 2074 6573 743e c22d oken.test>.-

Describe the results you expected:

Since the tunnel is programmed to be in DSCP Uniform mode, expected the DSCP from outer IPv4 header to be retained and test case should pass

redis-dump -d 1 -k "ASIC_STATE:SAI_OBJECT_TYPE_TUNNEL:*" -y { "ASIC_STATE:SAI_OBJECT_TYPE_TUNNEL:oid:0x2a0000000005a4": { "expireat": 1628282317.6948571, "ttl": -0.001, "type": "hash", "value": { "SAI_TUNNEL_ATTR_DECAP_DSCP_MODE": "SAI_TUNNEL_DSCP_MODE_UNIFORM_MODEL", "SAI_TUNNEL_ATTR_DECAP_ECN_MODE": "SAI_TUNNEL_DECAP_ECN_MODE_COPY_FROM_OUTER", "SAI_TUNNEL_ATTR_DECAP_TTL_MODE": "SAI_TUNNEL_TTL_MODE_PIPE_MODEL", "SAI_TUNNEL_ATTR_OVERLAY_INTERFACE": "oid:0x60000000005a3", "SAI_TUNNEL_ATTR_TYPE": "SAI_TUNNEL_TYPE_IPINIP", "SAI_TUNNEL_ATTR_UNDERLAY_INTERFACE": "oid:0x6000000000540" } },

Expected packet: 18:38:15.135576 c8:f7:50:ed:7c:c1 > 52:54:00:80:ca:b7, ethertype IPv4 (0x0800), length 60: (tos 0xc, ttl 63, id 1, offset 0, flags [none], proto Options (0), length 43) 1.1.1.1 > 1.0.0.0: ip-proto-0 23 0x0000: 5254 0080 cab7 c8f7 50ed 7cc1 0800 450c RT......P.|...E. 0x0010: 002b 0001 0000 3f00 78d1 0101 0101 0100 .+....?.x....... 0x0020: 0000 536f 6e69 6320 6465 6361 7020 6272 ..Sonic.decap.br 0x0030: 6f6b 656e 2074 6573 743e c22d oken.test>.-

Output of show version:

SONiC Software Version: SONiC.20201231.18
Distribution: Debian 10.10
Kernel: 4.19.0-12-2-amd64
Build commit: 67ec0a56e3
Build date: Wed Aug 18 13:54:53 UTC 2021
Built by: AzDevOps@sonic-int-build-workers-0002UW

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

Case CS00012202914 has been filed with Broadcom to track this

zhangyanzhao commented 3 years ago

Engaged with BRCM and BRCM is working on the fix.