[Z9332f] custom_led.bin failure during boot

[gechiang]

Description

Observed the following in the syslog for TH3 platforms during boot time:

Aug 17 18:35:47.979344  ERR syncd#syncd: [none] SAI_API_SWITCH:platform_process_command:436 Platform command "if $?feature_cmicx && !$?trident3 && !$?helix5 "m0 load 0 0x3800 ${led_fw_path}custom_led.bin"" failed, rc = -1.
Aug 17 18:35:47.979344  CRIT syncd#syncd: [none] SAI_API_SWITCH:platformInit:1961 initialization command "if $?feature_cmicx && !$?trident3 && !$?helix5 "m0 load 0 0x3800 ${led_fw_path}custom_led.bin"" failed, rc = -1 (Internal error)

Platform: x86_64-dellemc_z9332f_d1508-r0
HwSKU: DellEMC-Z9332f-O32
ASIC: broadcom
ASIC Count: 1

Suspect this is due to the introduction of the following PR: https://github.com/Azure/sonic-buildimage/pull/7964

Steps to reproduce the issue:

1. Just boot with the 20201231 image on a z9332f platform and then check the syslog to see the issue

Describe the results you expected:

It should not show this error

Output of show version:

admin@str2-z9332f-01:~$ show vers

SONiC Software Version: SONiC.20201231.19
Distribution: Debian 10.10
Kernel: 4.19.0-12-2-amd64
Build commit: caa4763e25
Build date: Wed Aug 25 13:23:00 UTC 2021
Built by: AzDevOps@sonic-int-build-workers-00032R

Platform: x86_64-dellemc_z9332f_d1508-r0
HwSKU: DellEMC-Z9332f-O32
ASIC: broadcom
ASIC Count: 1
Serial Number: TH04CN21CET0004K0214
Uptime: 20:49:08 up 4 min,  1 user,  load average: 0.58, 0.56, 0.27

[gechiang]

@aravindmani-1 Can you help take a look at this issue? It looks related to your PR (https://github.com/Azure/sonic-buildimage/pull/7964) Thanks!

[gechiang]

Debugged this issue and found it was due to missing soc property in config.bcm files to specify the path for the custom_led binary. Once specified "led_fw_path=/usr/share/sonic/hwsku/" then the failure is not seen.
Communicated the finding with DELL and DELL team has raised the PR.