search

sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
173 stars 691 forks source link

[test gap] Check if control acl rules match after loading acl.json #10516

Open ZhaohuiS opened 8 months ago

ZhaohuiS commented 8 months ago

Description Currently, there is no test case to check if cacl rules are correct after apply acl-loader. Need to check if acl rules match between the content of acl.json and the output of show acl rule and also the acl rule in redis. After the change of https://github.com/sonic-net/sonic-mgmt/issues/10426, the show acl rule output is different with before.

Steps to reproduce the issue: 1. 2. 3.

Describe the results you received:

Describe the results you expected:

Additional information you deem important:

**Output of `show version`:**

```
(paste your output here)
```

**Attach debug file `sudo generate_dump`:**

```
(paste your output here)
```
lizhijianrd commented 8 months ago

@ZhaohuiS Is there also a test gap for data plane? Default deny rule will not be added unless the table type is L3 or L3V6 now.

ZhaohuiS commented 8 months ago

@ZhaohuiS Is there also a test gap for data plane? Default deny rule will not be added unless the table type is L3 or L3V6 now.

@lizhijianrd Is it better to cover data plane acl rules in unit test? We can find out this kind of issue earlier before nightly test. Maybe for cacl, we can also consider to add this in unit test.

StormLiangMS commented 1 month ago

hi @ZhaohuiS seems your domain?