Description
The tests in snappi_tests/pfc/test_pfc_pause_lossy_with_snappi.py are failing.
These tests are reading the pfc counters from DUT, and expect them to be zero. But our DUT will count any PFC packet of any priority and it will show up in "show pfc counter". I have added a skip to this check in our workspace:
rraghav@sonic-ucs-m3-2:~/Ixia/whitebox/202305/sonic-test/sonic-mgmt/tests$ git diff common/snappi_tests/traffic_generation.py
diff --git a/sonic-mgmt/tests/common/snappi_tests/traffic_generation.py b/sonic-mgmt/tests/common/snappi_tests/traffic_generation.py
index 3fa78fcb3..c86cb3db6 100644
--- a/sonic-mgmt/tests/common/snappi_tests/traffic_generation.py
+++ b/sonic-mgmt/tests/common/snappi_tests/traffic_generation.py
@@ -609,8 +609,9 @@ def verify_pause_frame_count_dut(duthost,
"PFC pause frames should be received and counted in RX PFC counters for priority {}"
.format(prios[prio]))
else:
- pytest_assert(pfc_pause_rx_frames <= PFC_FRAME_COUNT_TOL,
- "PFC pause frames should not be received and counted in RX PFC counters")
+ pass
+ #pytest_assert(pfc_pause_rx_frames <= PFC_FRAME_COUNT_TOL,
+ # "PFC pause frames should not be received and counted in RX PFC counters")
Describe the results you received:
All tests failed:
<html xmlns:v="urn:schemas-microsoft-com:vml"
xmlns:o="urn:schemas-microsoft-com:office:office"
xmlns:x="urn:schemas-microsoft-com:office:excel"
xmlns="http://www.w3.org/TR/REC-html40">
test_pfc_pause_single_lossy_prio[rdma-m64\|0] | FALSE | failure | 42:09.3 | 46:02.2 | snappi_tests/pfc/test_pfc_pause_lossy_with_snappi.py | 20 | 232.747 | Failed: PFC pause frames should not be received and counted in RX PFC counters
-- | -- | -- | -- | -- | -- | -- | -- | --
test_pfc_pause_single_lossy_prio[rdma-m64\|1] | FALSE | failure | 46:02.2 | 49:06.3 | snappi_tests/pfc/test_pfc_pause_lossy_with_snappi.py | 20 | 183.997 | Failed: PFC pause frames should not be received and counted in RX PFC counters
test_pfc_pause_single_lossy_prio[rdma-m64\|2] | FALSE | failure | 49:06.3 | 52:10.4 | snappi_tests/pfc/test_pfc_pause_lossy_with_snappi.py | 20 | 184.13 | Failed: PFC pause frames should not be received and counted in RX PFC counters
test_pfc_pause_single_lossy_prio[rdma-m64\|5] | FALSE | failure | 52:10.4 | 55:24.2 | snappi_tests/pfc/test_pfc_pause_lossy_with_snappi.py | 20 | 193.779 | Failed: PFC pause frames should not be received and counted in RX PFC counters
test_pfc_pause_single_lossy_prio[rdma-m64\|6] | FALSE | failure | 55:24.2 | 58:39.0 | snappi_tests/pfc/test_pfc_pause_lossy_with_snappi.py | 20 | 194.77 | Failed: PFC pause frames should not be received and counted in RX PFC counters
Description The tests in snappi_tests/pfc/test_pfc_pause_lossy_with_snappi.py are failing.
These tests are reading the pfc counters from DUT, and expect them to be zero. But our DUT will count any PFC packet of any priority and it will show up in "show pfc counter". I have added a skip to this check in our workspace:
rraghav@sonic-ucs-m3-2:~/Ixia/whitebox/202305/sonic-test/sonic-mgmt/tests$ git diff common/snappi_tests/traffic_generation.py diff --git a/sonic-mgmt/tests/common/snappi_tests/traffic_generation.py b/sonic-mgmt/tests/common/snappi_tests/traffic_generation.py index 3fa78fcb3..c86cb3db6 100644 --- a/sonic-mgmt/tests/common/snappi_tests/traffic_generation.py +++ b/sonic-mgmt/tests/common/snappi_tests/traffic_generation.py @@ -609,8 +609,9 @@ def verify_pause_frame_count_dut(duthost, "PFC pause frames should be received and counted in RX PFC counters for priority {}" .format(prios[prio])) else: - pytest_assert(pfc_pause_rx_frames <= PFC_FRAME_COUNT_TOL, - "PFC pause frames should not be received and counted in RX PFC counters") + pass + #pytest_assert(pfc_pause_rx_frames <= PFC_FRAME_COUNT_TOL, + # "PFC pause frames should not be received and counted in RX PFC counters")
def verify_tx_frame_count_dut(duthost, rraghav@sonic-ucs-m3-2:~/Ixia/whitebox/202305/sonic-test/sonic-mgmt/tests$
Steps to reproduce the issue: Run the script : https://github.com/sonic-net/sonic-mgmt/blob/202305/tests/snappi_tests/pfc/test_pfc_pause_lossy_with_snappi.py
Describe the results you received: All tests failed: <html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns="http://www.w3.org/TR/REC-html40">
test_pfc_pause_single_lossy_prio[rdma-m64\|0] | FALSE | failure | 42:09.3 | 46:02.2 | snappi_tests/pfc/test_pfc_pause_lossy_with_snappi.py | 20 | 232.747 | Failed: PFC pause frames should not be received and counted in RX PFC counters -- | -- | -- | -- | -- | -- | -- | -- | -- test_pfc_pause_single_lossy_prio[rdma-m64\|1] | FALSE | failure | 46:02.2 | 49:06.3 | snappi_tests/pfc/test_pfc_pause_lossy_with_snappi.py | 20 | 183.997 | Failed: PFC pause frames should not be received and counted in RX PFC counters test_pfc_pause_single_lossy_prio[rdma-m64\|2] | FALSE | failure | 49:06.3 | 52:10.4 | snappi_tests/pfc/test_pfc_pause_lossy_with_snappi.py | 20 | 184.13 | Failed: PFC pause frames should not be received and counted in RX PFC counters test_pfc_pause_single_lossy_prio[rdma-m64\|5] | FALSE | failure | 52:10.4 | 55:24.2 | snappi_tests/pfc/test_pfc_pause_lossy_with_snappi.py | 20 | 193.779 | Failed: PFC pause frames should not be received and counted in RX PFC counters test_pfc_pause_single_lossy_prio[rdma-m64\|6] | FALSE | failure | 55:24.2 | 58:39.0 | snappi_tests/pfc/test_pfc_pause_lossy_with_snappi.py | 20 | 194.77 | Failed: PFC pause frames should not be received and counted in RX PFC counters