search

sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
200 stars 732 forks source link

snappi_dut_base_config takes only 3 args, but callers are having 4 args. #11999

Open rraghav-cisco opened 8 months ago

rraghav-cisco commented 8 months ago

https://github.com/sonic-net/sonic-mgmt/blob/b2522809a19ed5ba789b49f6bab8dfd73c314b0c/tests/common/snappi_tests/snappi_fixtures.py#L529

Below tests are failing since they have 4 args(tgen_ports is the extra arg). Multiple calls in this file: https://github.com/sonic-net/sonic-mgmt/blob/b2522809a19ed5ba789b49f6bab8dfd73c314b0c/tests/snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossy_with_snappi.py

FAILED snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossy_with_snappi.py::test_pfc_pause_single_lossy_prio[linecard_configuration_set0-chassis_single_line_card_multi_asic] - TypeError: snappi_dut_base_config() takes 3 positional arguments but 4 w...
FAILED snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossy_with_snappi.py::test_pfc_pause_multi_lossy_prio[linecard_configuration_set0-chassis_single_line_card_multi_asic] - TypeError: snappi_dut_base_config() takes 3 positional arguments but 4 we...
FAILED snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossy_with_snappi.py::test_pfc_pause_single_lossy_prio_reboot[linecard_configuration_set0-chassis_single_line_card_multi_asic-warm] - TypeError: snappi_dut_base_config() takes 3 positional argum...
FAILED snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossy_with_snappi.py::test_pfc_pause_single_lossy_prio_reboot[linecard_configuration_set0-chassis_single_line_card_multi_asic-cold] - TypeError: snappi_dut_base_config() takes 3 positional argum...
FAILED snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossy_with_snappi.py::test_pfc_pause_single_lossy_prio_reboot[linecard_configuration_set0-chassis_single_line_card_multi_asic-fast] - TypeError: snappi_dut_base_config() takes 3 positional argum...
FAILED snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossy_with_snappi.py::test_pfc_pause_multi_lossy_prio_reboot[linecard_configuration_set0-chassis_single_line_card_multi_asic-warm] - TypeError: snappi_dut_base_config() takes 3 positional argume...
FAILED snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossy_with_snappi.py::test_pfc_pause_multi_lossy_prio_reboot[linecard_configuration_set0-chassis_single_line_card_multi_asic-cold] - TypeError: snappi_dut_base_config() takes 3 positional argume...
FAILED snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossy_with_snappi.py::test_pfc_pause_multi_lossy_prio_reboot[linecard_configuration_set0-chassis_single_line_card_multi_asic-fast] - TypeError: snappi_dut_base_config() takes 3 positional argume...
rraghav-cisco commented 8 months ago

@sanmalho-git , @isgmano and @kamalsahu0001 : FYI.