sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
194 stars 714 forks source link

Subject: add qos_params for th5 asic #13407

Closed ccroy-arista closed 3 days ago

ccroy-arista commented 3 months ago

Summary:

ASIC-specific qos_params.py files are needed in order for the qos tests to run against the associated ASICs. This change adds a qos_params file for the Tomahawk5 (th5) ASIC. Additional speed/cable length params can be subsequently added to this file for the Tomahawk5 ASIC.

Fixes: https://github.com/aristanetworks/sonic-qual.msft/issues/159 Note: This PR works in conjunction with the community version of the qos_param_generator.py file to resolve the aforementioned issue. Note: The values contained in this PR are experimental and have not been fully verified beyond simply resolving the aforementioned issue.

Type of change

Back port request

Approach

What is the motivation for this PR?

Eliminate instances of KeyError: 'th5' being thrown when running qos tests, such as was identified in: https://github.com/aristanetworks/sonic-qual.msft/issues/159

How did you do it?

Added a qos params file specific to TH5.

How did you verify/test it?

Manual tested against a run of qos/test_qos_sai.py::TestQosSai on the topologies listed below, to verify the fix.

Supported testbed topology if it's a new test case?

This patch covers only the following topology names (additional topologies can be added as desired):

ccroy-arista commented 3 days ago

Closing as initial prototype work that won't be upstreamed.