search

sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
194 stars 714 forks source link

Remove TACACS fixture from none TACACS test cases #13422

Closed liuh-80 closed 3 months ago

liuh-80 commented 3 months ago

Remove TACACS fixture from none TACACS test cases

Why I did it

To improve TACACS feature coverage, will have a PR to enable TACACS on testbed for daily work and all test cases. before that change need remove TACACS fixture from none TACACS test cases first.

Work item tracking

How I did it

Remove TACACS fixture from none TACACS test cases.

How to verify it

Pass all test case.

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Remove TACACS fixture from none TACACS test cases

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

wsycqyz commented 3 months ago

Do we need the PR in 2024 or 2023 branch?

cyw233 commented 3 months ago

Do we need the PR in 2024 or 2023 branch?

good point, not sure about 202305 branch as this TACAS change is not in 202305 branch anyway, but I think we do need this in 202405 branch. Adding 202405 branch request label

StormLiangMS commented 3 months ago

hi @yxieca @bingwang-ms for 202311 / 202405 cherry pick.

mssonicbld commented 3 months ago

@liuh-80 PR conflicts with 202405 branch

cyw233 commented 3 months ago

@liuh-80 PR conflicts with 202405 branch

PR to merge into 202405 branch: https://github.com/sonic-net/sonic-mgmt/pull/13488