sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
194 stars 713 forks source link

Revert "Fix test_qos_sai teardown for dualtor (#13363)" #13436

Open XuChen-MSFT opened 3 months ago

XuChen-MSFT commented 3 months ago

This reverts commit 20c8cdff655a2f46412c1cab3e0dd675c9262e56.

Description of PR

Summary: Fixes # (issue)

Type of change

Back port request

Approach

What is the motivation for this PR?

PR #13363 caused qos sai tests error

2024-06-24 09:53:49.7980000 | qos.test_qos_sai.TestQosSai.testParameter[single_asic] | 202305 | error | failed on setup with "Failed: Not all critical processes are healthy"

How did you do it?

reverty PR #13363 can help.

How did you verify/test it?

pass qos sai test on local after revert pr #13363

Any platform specific information?

generic error

Supported testbed topology if it's a new test case?

Documentation

vivekverma-arista commented 3 months ago

@XuChen-MSFT On which platform and topology was this failure seen?

It would help us to debug further. Before raising this pull request this fix was tested across Arista platforms and topologies and no issues were seen. Again it may be another race condition among the fixtures.