sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
173 stars 689 forks source link

Skip forced mgmt route test if intf is invalid #13438

Closed dayouliu1 closed 5 days ago

dayouliu1 commented 2 weeks ago

Description of PR

Summary: Fixes #169

Type of change

Back port request

Approach

What is the motivation for this PR?

Skip test_forced_mgmt_route_add_and_remove_by_mgmt_port_status in route/test_forced_mgmt_route.py if eth1 does not exist or is being used. This test was failing on Arista platforms when interface eth1 did not exist.

How did you do it?

Added a check to see if eth1 does not exist, and skips the test if so.

How did you verify/test it?

Tested on a t0 setup on a Arista-7260

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

linux-foundation-easycla[bot] commented 2 weeks ago

CLA Signed


The committers listed above are authorized under a signed CLA.

StormLiangMS commented 1 week ago

hi @liuh-80 could you help to take a look?

StormLiangMS commented 1 week ago

/azp run Azure.sonic-mgmt

azure-pipelines[bot] commented 1 week ago
Azure Pipelines successfully started running 1 pipeline(s).
StormLiangMS commented 5 days ago

hi @liuh-80 let's leave the cherry pick approve to the release manager.

StormLiangMS commented 5 days ago

hi @yxieca for cherry pick.

mssonicbld commented 3 days ago

Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-mgmt/pull/13583

mssonicbld commented 3 days ago

Cherry-pick PR to 202311: https://github.com/sonic-net/sonic-mgmt/pull/13584