mssonicbld
commented
2 weeks ago The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.
Detailed pre-commit check results:
trim trailing whitespace.................................................Passedfix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1
.azure-pipelines/test_plan.py:168:26: E203 whitespace before ':'
flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed
To run the pre-commit checks locally, you can follow below steps:
- Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
- Ensure that the
pre-commitpackage is installed:sudo pip install pre-commit - Go to repository root folder
- Install the pre-commit hooks:
pre-commit install - Use pre-commit to check staged file:
pre-commit - Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>
Description of PR
Summary: Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
This is the second part of the work for eliminating client secrets.
This change depends on merge of #13435.
How did you do it?
This change updated the test_plan.py to get access token by az cli. For the az cli command to work, the task calling test_plan.py must be wrapped in an AzureCLI azure pipeline task.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation