mssonicbld
commented
1 week ago The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.
Detailed pre-commit check results:
trim trailing whitespace.................................................Passedfix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1
tests/saitests/py3/sai_qos_tests.py:4313:9: E303 too many blank lines (2)
tests/saitests/py3/sai_qos_tests.py:4941:9: E303 too many blank lines (2)
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped
To run the pre-commit checks locally, you can follow below steps:
- Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
- Ensure that the
pre-commitpackage is installed:sudo pip install pre-commit - Go to repository root folder
- Install the pre-commit hooks:
pre-commit install - Use pre-commit to check staged file:
pre-commit - Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>
Description of PR
SAI_PORT_STAT_IN/OUT_DROPPED_PKTS is not supported for DNX. #CS00012344046 Added a check in sonic-mgmt qos test for dnx , not to query this counter.
Summary: Fixes # (issue)
Type of change
Back port request
Approach
The sai-thrift_read_port_counters function will update the list for dnx and then read the counters.
What is the motivation for this PR?
How did you do it?
The sai-thrift_read_port_counters function will update the list for dnx and then read the counters. The test cases are updated accordingly in sai_qos_tests.py
How did you verify/test it?
Executed the qos test and verify the counters are read correctly.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation