Add watchdog timeout event test

zbud-msft commented 3 months ago

Description of PR

Summary: Fixes # (issue)26636373

Type of change

[ ] Bug fix
[ ] Testbed and Framework(new/improvement)
[ ] Test case(new/improvement)

Back port request

[ ] 202012
[ ] 202205
[ ] 202305
[ ] 202311
[ ] 202405

Approach

What is the motivation for this PR?

Add event for watchdog timeout

How did you do it?

Create mock test service that will sleep and therefore not send watchdog signal. This will generate watchdog timeout event

How did you verify/test it?

Manual test/Pipeline

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld commented 3 months ago

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:

trim trailing whitespace.................................................Passed fix end of files.........................................................Failed - hook id: end-of-file-fixer - exit code: 1 - files were modified by this hook Fixing tests/telemetry/events/events_data/test-watchdog-timeout.service check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/telemetry/events/event_utils.py:29:1: E302 expected 2 blank lines, found 1 tests/telemetry/events/host_events.py:39:17: E128 continuation line under-indented for visual indent flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
Ensure that the pre-commit package is installed:
```
sudo pip install pre-commit
```
Go to repository root folder
Install the pre-commit hooks:
```
pre-commit install
```
Use pre-commit to check staged file:
```
pre-commit
```

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld commented 3 months ago

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:

trim trailing whitespace.................................................Passed fix end of files.........................................................Failed - hook id: end-of-file-fixer - exit code: 1 - files were modified by this hook Fixing tests/telemetry/events/events_data/test-watchdog-timeout.service check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/telemetry/events/event_utils.py:29:1: E302 expected 2 blank lines, found 1 flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
Ensure that the pre-commit package is installed:
```
sudo pip install pre-commit
```
Go to repository root folder
Install the pre-commit hooks:
```
pre-commit install
```
Use pre-commit to check staged file:
```
pre-commit
```

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

zbud-msft commented 3 months ago

Relies on https://github.com/sonic-net/sonic-buildimage/pull/19383

wsycqyz commented 3 months ago

PR test is re-triggered.

azure-pipelines[bot] commented 2 months ago

Commenter does not have sufficient privileges for PR 13468 in repo sonic-net/sonic-mgmt

mssonicbld commented 1 month ago

Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-mgmt/pull/13952

zbud-msft commented 1 month ago

Hi @StormLiangMS, can we have this in 202311?

sonic-net / sonic-mgmt