mssonicbld
commented
3 months ago The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.
Detailed pre-commit check results:
trim trailing whitespace.................................................Failed- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook
Fixing tests/golden_config_infra/test_config_reload_with_rendered_golden_config.py
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook
Fixing tests/common/templates/goldel_config_db.j2
Fixing tests/golden_config_infra/templates/sample_goldel_config_db.j2
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Passed
flake8...............................................(no files to check)Skipped
...
[truncated extra lines, please run pre-commit locally to view full check results]
To run the pre-commit checks locally, you can follow below steps:
- Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
- Ensure that the
pre-commitpackage is installed:sudo pip install pre-commit - Go to repository root folder
- Install the pre-commit hooks:
pre-commit install - Use pre-commit to check staged file:
pre-commit - Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>
isabelmsft
bingwang-ms
wen587
Description of PR
Summary: This PR is to build a test insfrasture to simulate the process of Golden Config override with new table or exisitint tables. Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
There is a need to validate new feature or new tables without change in minigraph parser. Here we setup a test infrastructure to mimic the behavior of Golden Config override process and override ConfigDB with the desired template.
How did you do it?
Define a new way of config reload with override. Add a common template to generate common feature and add a test case to generate specific table to test.
How did you verify/test it?
E2E test
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation