search

sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
194 stars 712 forks source link

Add xfail for NTP test case due to iburst not being enabled by default #13501

Closed saiarcot895 closed 3 months ago

saiarcot895 commented 3 months ago

Description of PR

Summary: Fixes # (issue)

Type of change

Back port request

Approach

What is the motivation for this PR?

From 202311 onwards, since iburst isn't enabled by default, there's a chance that NTP may fail to quickly synchronize the time. Details are in sonic-net/sonic-buildimage#19425.

How did you do it?

Add an xfail for that until it's handled.

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

saiarcot895 commented 3 months ago

/azpw run Azure.sonic-mgmt

mssonicbld commented 3 months ago

/AzurePipelines run Azure.sonic-mgmt

azure-pipelines[bot] commented 3 months ago
Azure Pipelines successfully started running 1 pipeline(s).
mssonicbld commented 3 months ago

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Failed
- hook id: check-conditional-mark-sort
- exit code: 1

The entries in tests/common/plugins/conditional_mark/tests_mark_conditions.yaml tests/common/plugins/conditional_mark/tests_mark_conditions_acl.yaml tests/common/plugins/conditional_mark/tests_mark_conditions_drop_packets.yaml tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml tests/common/plugins/conditional_mark/tests_mark_conditions_skip_traffic_test.yaml are not sorted in alphabetic order.

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
  2. Ensure that the pre-commit package is installed: 
    sudo pip install pre-commit
  3. Go to repository root folder
  4. Install the pre-commit hooks: 
    pre-commit install
  5. Use pre-commit to check staged file: 
    pre-commit
  6. Alternatively, you can check committed files using: 
    pre-commit run --from-ref <commit_id> --to-ref <commit_id>
wsycqyz commented 3 months ago

Do we need to cherry-pick to 2024 or 2023 branch?

mssonicbld commented 2 months ago

Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-mgmt/pull/13550

mssonicbld commented 2 months ago

Cherry-pick PR to 202311: https://github.com/sonic-net/sonic-mgmt/pull/13551