mssonicbld
commented
2 months ago The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.
Detailed pre-commit check results:
trim trailing whitespace.................................................Failed- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook
Fixing tests/common/snappi_tests/read_pcap.py
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Passed
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped
To run the pre-commit checks locally, you can follow below steps:
- Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
- Ensure that the
pre-commitpackage is installed:sudo pip install pre-commit - Go to repository root folder
- Install the pre-commit hooks:
pre-commit install - Use pre-commit to check staged file:
pre-commit - Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>
bingwang-ms
developfast
Description of PR
Summary: Add polling delay to ecn snappi test to account for ecn changes being made on the device. Also make packet capturing stricter with capturing any host internal protocol packets instead of other protocol type IP packets such as TCP packets. Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Bug fix
How did you do it?
Added polling delay as well as another if check on packet captures.
How did you verify/test it?
Tested on lab device
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation