sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
173 stars 689 forks source link

Remove xfail marker of ecmp/test_ecmp_sai_value.py #13538

Closed Gfrom2016 closed 35 minutes ago

Gfrom2016 commented 6 days ago

Description of PR

Summary: Fixes #11310 LAG and ECMP hash offset support has merged in 202311 https://github.com/sonic-net/sonic-swss/pull/3138, remove the xfail marker of ecmp/test_ecmp_sai_value.py

Type of change

Back port request

Approach

What is the motivation for this PR?

After https://github.com/sonic-net/sonic-swss/pull/3138, configure hash_offset along with hash_seed attribute is enabled on 202311 onwards on Broadcom T1 platfrom.

How did you do it?

Remove the xfail marker of ecmp/test_ecmp_sai_value.py

How did you verify/test it?

Run ecmp/test_ecmp_sai_values.py on 7260 T1 DUT and passed. https://dev.azure.com/mssonic/internal/_build/results?buildId=586225&view=results

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

ZhaohuiS commented 6 days ago

@Gfrom2016 is the code change included in sonic-buildimage 202405 branch? please hold on this PR until the new 202311 image is released.

Gfrom2016 commented 6 days ago

@Gfrom2016 is the code change included in sonic-buildimage 202405 branch? please hold on this PR until the new 202311 image is released.

I have added 'Request for 202405 image' label, will merge this after the image fix is merged. Thanks for the reminder.

wsycqyz commented 5 days ago

PR test re-triggeered.

Gfrom2016 commented 1 day ago

@StormLiangMS Could you help merge this?

mssonicbld commented 30 minutes ago

Cherry-pick PR to 202311: https://github.com/sonic-net/sonic-mgmt/pull/13600

mssonicbld commented 30 minutes ago

Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-mgmt/pull/13601