Summary:
Refine the output of conditional_mark order check.
Print more detailed information so that contributors know where to modify.
Before enhance, only tell there's mis-order, but not how to modify.
check conditional mark sort..............................................Failed
- hook id: check-conditional-mark-sort
- exit code: 1
The entries in tests/common/plugins/conditional_mark/tests_mark_conditions*.yaml are not sorted in alphabetic order.
After enhance:
check conditional mark sort..............................................Failed
- hook id: check-conditional-mark-sort
- exit code: 1
The entries in tests/common/plugins/conditional_mark/tests_mark_conditions*.yaml are not sorted in alphabetic order.
The entries in tests/common/plugins/conditional_mark/tests_mark_conditions*.yaml are not sorted in alphabetic order, please adjust the order before commit
===========================================================================
File: tests\common\plugins\conditional_mark\tests_mark_conditions_skip_traffic_test.yaml
===========================================================================
Conditional marks before sort: ['acl/custom_acl_table/test_custom_acl_table.py', 'acl/null_route/test_null_route_helper.py', 'acl/test_acl.py', 'acl/test_acl_outer_vlan.py', 'acl/test_stress_acl.py', 'arp/test_stress_arp.py', 'arp/test_unknown_mac.py', 'arp/test_wr_arp.py', 'decap/test_decap.py', 'ecmp/inner_hashing/test_inner_hashing.py', 'ecmp/inner_hashing/test_inner_hashing_lag.py', 'ecmp/inner_hashing/test_inner_hashing.py:1', 'ecmp/inner_hashing/test_wr_inner_hashing.py', 'ecmp/inner_hashing/test_wr_inner_hashing_lag.py', 'everflow/test_everflow_ipv6.py', 'everflow/test_everflow_per_interface.py', 'everflow/test_everflow_testbed.py']
Conditional marks after sort: ['acl/custom_acl_table/test_custom_acl_table.py', 'acl/null_route/test_null_route_helper.py', 'acl/test_acl.py', 'acl/test_acl_outer_vlan.py', 'acl/test_stress_acl.py', 'arp/test_stress_arp.py', 'arp/test_unknown_mac.py', 'arp/test_wr_arp.py', 'decap/test_decap.py', 'ecmp/inner_hashing/test_inner_hashing.py', 'ecmp/inner_hashing/test_inner_hashing.py:1', 'ecmp/inner_hashing/test_inner_hashing_lag.py', 'ecmp/inner_hashing/test_wr_inner_hashing.py', 'ecmp/inner_hashing/test_wr_inner_hashing_lag.py', 'everflow/test_everflow_ipv6.py', 'everflow/test_everflow_per_interface.py', 'everflow/test_everflow_testbed.py']
===========================================================================
Mismatch item, before sort: ecmp/inner_hashing/test_inner_hashing_lag.py, after sort: ecmp/inner_hashing/test_inner_hashing.py:1
===========================================================================
Process finished with exit code 1
Type of change
[ ] Bug fix
[ ] Testbed and Framework(new/improvement)
[ ] Test case(new/improvement)
Back port request
[ ] 202012
[ ] 202205
[ ] 202305
[ ] 202311
[ ] 202405
Approach
What is the motivation for this PR?
Refine the output of conditional_mark order check.
Print more detailed information so that contributors know where to modify.
How did you do it?
Print detailed mis-order item
How did you verify/test it?
Local test
Any platform specific information?
Supported testbed topology if it's a new test case?
Description of PR
Summary: Refine the output of conditional_mark order check. Print more detailed information so that contributors know where to modify.
Before enhance, only tell there's mis-order, but not how to modify.
After enhance:
Type of change
Back port request
Approach
What is the motivation for this PR?
Refine the output of conditional_mark order check. Print more detailed information so that contributors know where to modify.
How did you do it?
Print detailed mis-order item
How did you verify/test it?
Local test
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation