sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
194 stars 713 forks source link

Adding support for PFCWD cases for pfcQueueGroupSize of 4 #13546

Closed selldinesh closed 2 months ago

selldinesh commented 3 months ago

Description of PR

Summary: Adding support for PFCWD cases for pfcQueueGroupSize of 4 Fixes # (issue)

Type of change

Back port request

Approach

What is the motivation for this PR?

This PR supports pfcQueueGroupSize of 4 for pfcwd cases , currently the support is for 8

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

sdszhang commented 3 months ago

@amitpawar12 pls review, thanks.

amitpawar12 commented 2 months ago

No comments.

amitpawar12 commented 2 months ago

Can you please also add the priority<->queue mapping support for the PFC oversubscription testcases as well?

tests/snappi_tests/multidut/pfc/files/lossless_response_to_external_pause_storms_helper.py tests/snappi_tests/multidut/pfc/files/lossless_response_to_throttling_pause_storms_helper.py tests/snappi_tests/multidut/pfc/files/m2o_fluctuating_lossless_helper.py tests/snappi_tests/multidut/pfc/files/m2o_oversubscribe_lossless_helper.py tests/snappi_tests/multidut/pfc/files/m2o_oversubscribe_lossless_lossy_helper.py tests/snappi_tests/multidut/pfc/files/m2o_oversubscribe_lossy_helper.py

Thanks, -A

abdosi commented 2 months ago

tests/snappi_tests/multidut/pfc/files/lossless_response_to_throttling_pause_storms_helper.py

  1. Existing testcase do not have Queue Counter validation as checkmark. @selldinesh
  2. Fix the Flow to Queue Mapping for below tests @amitpawar12
tests/snappi_tests/multidut/pfc/files/lossless_response_to_external_pause_storms_helper.py
tests/snappi_tests/multidut/pfc/files/lossless_response_to_throttling_pause_storms_helper.py
tests/snappi_tests/multidut/pfc/files/m2o_fluctuating_lossless_helper.py
tests/snappi_tests/multidut/pfc/files/m2o_oversubscribe_lossless_helper.py
tests/snappi_tests/multidut/pfc/files/m2o_oversubscribe_lossless_lossy_helper.py
tests/snappi_tests/multidut/pfc/files/m2o_oversubscribe_lossy_helper.py
sdszhang commented 2 months ago
  1. Existing testcase do not have Queue Counter validation as checkmark.
    -- Tracked in #13596

  2. Fix the Flow to Queue Mapping for below tests. @amitpawar12 Can you share the issue ID to track this item?

yejianquan commented 2 months ago
  1. Existing testcase do not have Queue Counter validation as checkmark. -- Tracked in [PFC] DUT counter check missing in verification for oversubscription cases #13596
  2. Fix the Flow to Queue Mapping for below tests. @amitpawar12 Can you share the issue ID to track this item?

I can help to merge this PR, @sdszhang could you create an issue and assign to Amit?

sdszhang commented 2 months ago
  1. Existing testcase do not have Queue Counter validation as checkmark. -- Tracked in [PFC] DUT counter check missing in verification for oversubscription cases #13596
  2. Fix the Flow to Queue Mapping for below tests. @amitpawar12 Can you share the issue ID to track this item?

I can help to merge this PR, @sdszhang could you create an issue and assign to Amit?

@yejianquan #13737 Added.

mssonicbld commented 2 months ago

Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-mgmt/pull/13738

amitpawar12 commented 2 months ago
  1. Existing testcase do not have Queue Counter validation as checkmark. -- Tracked in [PFC] DUT counter check missing in verification for oversubscription cases #13596
  2. Fix the Flow to Queue Mapping for below tests. @amitpawar12 Can you share the issue ID to track this item?

I can help to merge this PR, @sdszhang could you create an issue and assign to Amit?

@yejianquan #13737 Added.

Hi @sdszhang , @yejianquan - Raised - #13687 for the item (2).

Thanks, -A