mssonicbld
commented
4 days ago The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.
Detailed pre-commit check results:
trim trailing whitespace.................................................Passedfix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1
ansible/module_utils/port_utils.py:246:14: E127 continuation line over-indented for visual indent
ansible/module_utils/port_utils.py:247:14: E127 continuation line over-indented for visual indent
ansible/module_utils/port_utils.py:248:14: E127 continuation line over-indented for visual indent
ansible/module_utils/port_utils.py:249:14: E127 continuation line over-indented for visual indent
ansible/module_utils/port_utils.py:250:14: E127 continuation line over-indented for visual indent
ansible/module_utils/port_utils.py:254:63: E201 whitespace after '('
flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed
To run the pre-commit checks locally, you can follow below steps:
- Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
- Ensure that the
pre-commitpackage is installed:sudo pip install pre-commit - Go to repository root folder
- Install the pre-commit hooks:
pre-commit install - Use pre-commit to check staged file:
pre-commit - Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>
wsycqyz
linux-foundation-easycla[bot]
kenneth-arista
Description of PR
Primiarly add support for various Arista 7800R3A SKUs s to port_utils.py. Also one minor tweak
config_sonic_basedon_testbed.ymlto parameterizeasic_topo_configper slot.Summary:
Type of change
Back port request
Approach
What is the motivation for this PR? How did you do it?
Support all 7800R3A SKU variants
How did you verify/test it?
Validated with sonic-mgmt runs against Arista 7800R3A linecards.
Any platform specific information?
NA
Supported testbed topology if it's a new test case?
NA
Documentation
This is not a new feature and hence does not require a Wiki change.