Skip initializing exabgp for topologies that doesn't have any VMs.

r12f commented 4 days ago

Description of PR

This PR is trying to fix the add-topo failure when deploying any topology with no VMs.

Summary: Fixes # (issue)

Type of change

[ ] Bug fix
[X] Testbed and Framework(new/improvement)
[ ] Test case(new/improvement)

Back port request

[ ] 202012
[ ] 202205
[ ] 202305
[X] 202311
[X] 202405

Approach

What is the motivation for this PR?

When deploying topologies without VMs, such as t0-standalone-*, we will run into problems where exabgpv4/v6 returns process group already running as below:

The reason is that the configuration doesn't contain any VMs, hence results in an empty process group as below:

This makes supervisorctl somehow returns failure, because it thinks all processes are already active.

How did you do it?

To fix this issue, we can skip the supervisorctl add task when we don't have any VMs in the topology.

How did you verify/test it?

Have run it after the fix and add-topo starts to working.

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

N/A

Documentation

N/A

mssonicbld commented 3 days ago

Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-mgmt/pull/13585

mssonicbld commented 3 days ago

@r12f PR conflicts with 202311 branch

sonic-net / sonic-mgmt