mssonicbld
commented
3 days ago The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.
Detailed pre-commit check results:
trim trailing whitespace.................................................Passedfix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1
tests/conftest.py:1657:1: E302 expected 2 blank lines, found 1
tests/conftest.py:1673:121: E501 line too long (151 > 120 characters)
tests/conftest.py:1675:1: E302 expected 2 blank lines, found 1
tests/conftest.py:1691:121: E501 line too long (153 > 120 characters)
tests/conftest.py:1693:1: E302 expected 2 blank lines, found 1
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped
To run the pre-commit checks locally, you can follow below steps:
- Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
- Ensure that the
pre-commitpackage is installed:sudo pip install pre-commit - Go to repository root folder
- Install the pre-commit hooks:
pre-commit install - Use pre-commit to check staged file:
pre-commit - Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>
Description of PR
Summary: The modifications to test_bgp_suppress_fib.py are intended to adapt the script for a T2 topology with a multi-ASIC, multi-DUT chassis configuration
Type of change
Back port request
Approach
What is the motivation for this PR?
Extending the fib suppress use case to T2 Chassis topology as well
How did you do it?
Revise the code from being tailored to a T1-specific use case to a more generic framework that supports both upstream and downstream traffic, while also accommodating multi-ASIC and multi-DUT scenarios.
How did you verify/test it?
Tested on t1 topology
Tested on t2 multi asic , multi dut chassis topology
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation