sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
173 stars 689 forks source link

[action] [PR:13572] Skip initializing exabgp for topologies that doesn't have any VMs. #13585

Closed mssonicbld closed 1 day ago

mssonicbld commented 3 days ago

Description of PR

This PR is trying to fix the add-topo failure when deploying any topology with no VMs.

Summary: Fixes # (issue)

Type of change

Back port request

Approach

What is the motivation for this PR?

When deploying topologies without VMs, such as t0-standalone-*, we will run into problems where exabgpv4/v6 returns process group already running as below:

image

The reason is that the configuration doesn't contain any VMs, hence results in an empty process group as below:

image

This makes supervisorctl somehow returns failure, because it thinks all processes are already active.

image

How did you do it?

To fix this issue, we can skip the supervisorctl add task when we don't have any VMs in the topology.

How did you verify/test it?

Have run it after the fix and add-topo starts to working.

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

N/A

Documentation

N/A

mssonicbld commented 3 days ago

Original PR: https://github.com/sonic-net/sonic-mgmt/pull/13572

mssonicbld commented 2 days ago

/azp run Azure.sonic-mgmt

azure-pipelines[bot] commented 2 days ago
Azure Pipelines successfully started running 1 pipeline(s).