search

sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
200 stars 725 forks source link

[PFC] DUT counter check missing in verification for oversubscription cases #13596

Open selldinesh opened 3 months ago

selldinesh commented 3 months ago

Test Gap Description

This issue is to track the addition of dut counter verification part for the pfc oversubscribtion cases

Test Plan

For over-subscribtion cases under snappi_tests/multidut/pfc

Test environment

No response

Attach files (if any)

No response

yxieca commented 3 months ago

@selldinesh @sdszhang is this issue fully addressed by #13546? If not, please scope the remaining issues.

sdszhang commented 3 months ago

@yxieca #13546 added the main support in. However, there are two remaining tasks to be addressed:

  1. Existing testcase do not have Queue Counter validation as checkmark. Tracked via issue #13596
  2. Fix the Flow to Queue Mapping for below tests. Tracked via issue #13687 Both issues will be worked on by @selldinesh
yxieca commented 3 months ago

Thanks @sdszhang should this issue be closed since remaining issues are tracked by other 2 issues?

sdszhang commented 3 months ago

Thanks @sdszhang should this issue be closed since remaining issues are tracked by other 2 issues?

@yxieca The original PR # 13546 has been closed. This issue is one of the 2 issues to track the remaining tasks. The remaining two tasks is tracked in this issue (#13596) and #13687.

selldinesh commented 1 month ago

Added the fix in https://github.com/sonic-net/sonic-mgmt/pull/14416