sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
201 stars 728 forks source link

snappi_tests: ecnconfig causes failure #14126

Open rraghav-cisco opened 2 months ago

rraghav-cisco commented 2 months ago

https://github.com/sonic-net/sonic-mgmt/blob/390edf0042710f055d637e1f960a00fa98bbd353/tests/common/snappi_tests/common_helpers.py#L493

This line seems to be spuriosly added. Pls fix this line, it gives this error:

        if (res.is_failed or 'exception' in res) and not module_ignore_errors:
>           raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)
E           tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
E           {"changed": true, "cmd": "sudo ip netns exec asic0 ecnconfig 3", "delta": "0:00:00.085291", "end": "2024-08-14 20:00:20.362485", "failed": true, "msg": "non-zero return code", "rc": 2, "start": "2024-08-14 20:00:20.277194", "stderr": "usage: ecnconfig [-h] [-l] [-p PROFILE] [-gmin GREEN_MIN] [-gmax GREEN_MAX]\n                 [-ymin YELLOW_MIN] [-ymax YELLOW_MAX] [-rmin RED_MIN]\n                 [-rmax RED_MAX] [-gdrop GREEN_DROP_PROB]\n                 [-ydrop YELLOW_DROP_PROB] [-rdrop RED_DROP_PROB] [-v] [-vv]\n                 [-q QUEUE] [-f FILENAME]\n                 [{on,off}]\necnconfig: error: argument command: invalid choice: '3' (choose from 'on', 'off')", "stderr_lines": ["usage: ecnconfig [-h] [-l] [-p PROFILE] [-gmin GREEN_MIN] [-gmax GREEN_MAX]", "                 [-ymin YELLOW_MIN] [-ymax YELLOW_MAX] [-rmin RED_MIN]", "                 [-rmax RED_MAX] [-gdrop GREEN_DROP_PROB]", "                 [-ydrop YELLOW_DROP_PROB] [-rdrop RED_DROP_PROB] [-v] [-vv]", "                 [-q QUEUE] [-f FILENAME]", "                 [{on,off}]", "ecnconfig: error: argument command: invalid choice: '3' (choose from 'on', 'off')"], "stdout": "", "stdout_lines": [], "warnings": ["Consider using 'become', 'become_method', and 'become_user' rather than running sudo"]}

complex_args = {}
filename   = '/data/tests/common/devices/multi_asic.py'
function_name = '_run_on_asics'
index      = 0
line_number = 134
lines      = ['            return getattr(self.sonichost, self.multi_asic_attr)(*module_args, **complex_args)\n']
module_args = ['sudo ip netns exec asic0 ecnconfig 3']
module_async = False
module_ignore_errors = False
previous_frame = <frame at 0x7f9ab3647dd0, file '/data/tests/common/devices/multi_asic.py', line 134, code _run_on_asics>
res        = {'failed': True, 'msg': 'non-zero return code', 'cmd': 'sudo ip netns exec asic0 ecnconfig 3', 'stdout': '', 'stderr':...off}]', "ecnconfig: error: argument command: invalid choice: '3' (choose from 'on', 'off')"], '_ansible_no_log': False}
self       = <SonicHost yy39top-lc4>
verbose    = True
rraghav-cisco commented 2 months ago

@selldinesh , @kamalsahu0001 : FYI. @sdszhang : I will add this to the tracking sheet.