[Bug]: “Syncd crashes when some attr is not supported by the ASIC in GET operation”

[kaushiksrivatsav]

Issue Description

when a not supported attribute on the asic returns fail for get operation syncd is crashing.

Results you see

24 Aug 20 05:59:06.202563 DUT-1 NOTICE swss#orchagent: :- initializePort: Initializing port alias:Ethernet0 pid:1000000000001 2024 Aug 20 05:59:06.203940 DUT-1 WARNING syncd#syncd: xpSaiUtil.c:2087 [Attribute SAI_PORT_ATTR_NUMBER_OF_INGRESS_PRIORITY_GROUPS : Operation : 3] with given values is not supported 2024 Aug 20 05:59:06.205052 DUT-1 ERR swss#orchagent: :- initializePriorityGroups: Failed to get number of priority groups for port Ethernet0 rv:-327680 2024 Aug 20 05:59:06.205052 DUT-1 ERR swss#orchagent: :- handleSaiGetStatus: Encountered failure in get operation, SAI API: SAI_API_PORT, status: SAI_STATUS_ATTR_NOT_SUPPORTED_0 2024 Aug 20 05:59:06.208837 DUT-1 INFO swss#supervisord: orchagent terminate called after throwing an instance of 'std::runtime_error' 2024 Aug 20 05:59:06.210473 DUT-1 INFO swss#supervisord: orchagent what(): PortsOrch initialization failure.

Results you expected to see

the syncd to not crash when an unsupported attribute is returning failure.

Is it platform specific

marvell

Relevant log output

24 Aug 20 05:59:06.202563 DUT-1 NOTICE swss#orchagent: :- initializePort: Initializing port alias:Ethernet0 pid:1000000000001
2024 Aug 20 05:59:06.203940 DUT-1 WARNING syncd#syncd: xpSaiUtil.c:2087 [Attribute SAI_PORT_ATTR_NUMBER_OF_INGRESS_PRIORITY_GROUPS : Operation : 3] with given values is not supported
2024 Aug 20 05:59:06.205052 DUT-1 ERR swss#orchagent: :- initializePriorityGroups: Failed to get number of priority groups for port Ethernet0 rv:-327680
2024 Aug 20 05:59:06.205052 DUT-1 ERR swss#orchagent: :- handleSaiGetStatus: Encountered failure in get operation, SAI API: SAI_API_PORT, status: SAI_STATUS_ATTR_NOT_SUPPORTED_0
2024 Aug 20 05:59:06.208837 DUT-1 INFO swss#supervisord: orchagent terminate called after throwing an instance of 'std::runtime_error'
2024 Aug 20 05:59:06.210473 DUT-1 INFO swss#supervisord: orchagent   what():  PortsOrch initialization failure.

Output of show version

SONiC Software Version: SONiC.202405.0-dirty-20240730.123718
SONiC OS Version: 12
Distribution: Debian 12.5
Kernel: 6.1.0-11-2-arm64
Build commit: aa41c758c
Build date: Tue Jul 30 12:38:01 UTC 2024
Built by: marvell@cpss-arm-vm03

Platform: arm64-marvell_rd98DX35xx_cn9131-r0
HwSKU: rd98DX35xx_cn9131
ASIC: marvell
ASIC Count: 1
Serial Number: NA
Model Number: NA
Hardware Revision: N/A
Uptime: 05:31:29 up 13:49,  1 user,  load average: 0.55, 0.49, 0.48
Date: Thu 22 Aug 2024 05:31:29

Docker images:
REPOSITORY                    TAG                              IMAGE ID       SIZE
docker-syncd-mrvl-rpc         202405.0-dirty-20240730.123718   67b05663cf7a   635MB
docker-syncd-mrvl-rpc         latest                           67b05663cf7a   635MB
docker-macsec                 latest                           bd26712bdd58   515MB
docker-dhcp-relay             latest                           ec31ee4f9668   494MB
docker-teamd                  202405.0-dirty-20240730.123718   24bc142b14e8   512MB
docker-teamd                  latest                           24bc142b14e8   512MB
docker-sonic-mgmt-framework   202405.0-dirty-20240730.123718   d3002a58718a   530MB
docker-sonic-mgmt-framework   latest                           d3002a58718a   530MB
docker-snmp                   202405.0-dirty-20240730.123718   7567f4e5fb13   525MB
docker-snmp                   latest                           7567f4e5fb13   525MB
docker-sflow                  202405.0-dirty-20240730.123718   8ff35382ffd6   513MB
docker-sflow                  latest                           8ff35382ffd6   513MB
docker-router-advertiser      202405.0-dirty-20240730.123718   fd4585a6eb3b   484MB
docker-router-advertiser      latest                           fd4585a6eb3b   484MB
docker-platform-monitor       202405.0-dirty-20240730.123718   f26f018d0500   839MB
docker-platform-monitor       latest                           f26f018d0500   839MB
docker-orchagent              202405.0-dirty-20240730.123718   d8239b5bef47   526MB
docker-orchagent              latest                           d8239b5bef47   526MB
docker-nat                    202405.0-dirty-20240730.123718   0b8c0af8c33b   521MB
docker-nat                    latest                           0b8c0af8c33b   521MB
docker-mux                    202405.0-dirty-20240730.123718   44fc738e1241   499MB
docker-mux                    latest                           44fc738e1241   499MB
docker-lldp                   202405.0-dirty-20240730.123718   a0eae43277b7   491MB
docker-lldp                   latest                           a0eae43277b7   491MB
docker-sonic-gnmi             202405.0-dirty-20240730.123718   ee8dae4d8c76   565MB
docker-sonic-gnmi             latest                           ee8dae4d8c76   565MB
docker-fpm-frr                202405.0-dirty-20240730.123718   1863630daa32   545MB
docker-fpm-frr                latest                           1863630daa32   545MB
docker-eventd                 202405.0-dirty-20240730.123718   2ff7fe50df5c   484MB
docker-eventd                 latest                           2ff7fe50df5c   484MB
docker-database               202405.0-dirty-20240730.123718   f64b2534d932   492MB
docker-database               latest                           f64b2534d932   492MB

Attach files (if any)

No response