sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
201 stars 725 forks source link

Test gap for lldp APPL_DB data consistency #14216

Closed ZhaohuiS closed 1 month ago

ZhaohuiS commented 2 months ago

Description of PR

Summary: Fixes # (issue) Address https://github.com/sonic-net/sonic-mgmt/issues/13937

ADO:28941599

Type of change

Back port request

Approach

What is the motivation for this PR?

To address https://github.com/sonic-net/sonic-mgmt/issues/13937 Test plan: https://github.com/sonic-net/sonic-mgmt/pull/14080

How did you do it?

Add a new test script to test lldp APPL_DB data consistency

How did you verify/test it?

run lldp/test_lldp_syncd.py

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

yutongzhang-microsoft commented 2 months ago

Hi, @ZhaohuiS , can you help me confirm if this new added test script can run in PR test?

ZhaohuiS commented 1 month ago

Hi, @ZhaohuiS , can you help me confirm if this new added test script can run in PR test?

@yutongzhang-microsoft It should be able to run on kvm testbed.

yejianquan commented 1 month ago

@ZhaohuiS do we need it in 202405 branch?

mssonicbld commented 1 month ago

@ZhaohuiS PR conflicts with 202405 branch

mssonicbld commented 1 month ago

@ZhaohuiS PR conflicts with 202311 branch

bingwang-ms commented 4 weeks ago

@ZhaohuiS The test case is failing with error .

  File "/var/src/sonic-mgmt_vms2-4-t0-2700_646f1405735219c3e54440f2/tests/lldp/test_lldp_syncd.py", line 36, in get_lldp_entry_content
    return db.hget_all("LLDP_ENTRY_TABLE:{}".format(interface))
AttributeError: 'SonicDbCli' object has no attribute 'hget_all'

Is there any dependent PR not merged?

bingwang-ms commented 4 weeks ago

Issue fixed in PR https://github.com/sonic-net/sonic-mgmt/pull/14846