Fix flaky test_reload_configuration_checks when all processes are not…

tudupa commented 2 months ago

… up during swss stop job

Type of change

[ ] Bug fix
[ ] Testbed and Framework(new/improvement)
[x] Test case(new/improvement)

Back port request

[ ] 202012
[ ] 202205
[ ] 202305
[x] 202311
[x] 202405

Approach

What is the motivation for this PR?

The testcase test_reload_configuration_checks fails sometimes when swss is stopped after a config reload and some of the critical processes are still coming up. The stop job of swss in the queue is cancelled due to other critical processes still coming up and trying to bring up swss. Hence, we get the error - "Job for swss.service cancelled"

How did you do it?

This PR enhanced the testcase to wait until all the critical processes are up after a config reload and then execute a stop job for swss.

How did you verify/test it?

Ran the testcase 15-20 times to see if it fails.

Any platform specific information?

NA

Supported testbed topology if it's a new test case?

NA

prgeor commented 2 months ago

@tudupa please fix the build errors

tudupa commented 2 months ago

/azpw run Azure.sonic-mgmt

mssonicbld commented 2 months ago

/AzurePipelines run Azure.sonic-mgmt

azure-pipelines[bot] commented 2 months ago

Azure Pipelines successfully started running 1 pipeline(s).

lizhijianrd commented 2 months ago

PR test failed due to #14247. The testcase will be skipped once #14248 is merged.

lizhijianrd commented 2 months ago

/azpw run Azure.sonic-mgmt

lizhijianrd commented 2 months ago

@tudupa Can you please help comment /azpw run Azure.sonic-mgmt to re-trigger the PR test? The PR test issue has been resolved. But I don't have permission to re-trigger it so I need your help. Thanks!

tudupa commented 2 months ago

/azpw run Azure.sonic-mgmt

mssonicbld commented 2 months ago

/AzurePipelines run Azure.sonic-mgmt

azure-pipelines[bot] commented 2 months ago

Azure Pipelines successfully started running 1 pipeline(s).

lizhijianrd commented 2 months ago

@bingwang-ms @yxieca Can you please help add approval tag for backport 202405/202311, thank you!

mssonicbld commented 2 months ago

Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-mgmt/pull/14298

mssonicbld commented 2 months ago

Cherry-pick PR to 202311: https://github.com/sonic-net/sonic-mgmt/pull/14302

sonic-net / sonic-mgmt