search

sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
200 stars 730 forks source link

[Snappi][Broadcom] Support to enable/disable Credit-watchdog post SAI 11.x version for Snappi testcases. #14635

Open amitpawar12 opened 2 months ago

amitpawar12 commented 2 months ago

Issue Description

Snappi test cases for PFC - tests/snappi_tests/multidut/pfc/ rely on disabling credit-watchdog at the start of the test and enabling it as part of the test-cleanup.

The process of enabling/disabling credit-watchdog was done via Broadcom shell CLI.

However, post SAI 11.x versions, this command will not be supported and hence testcases need to find way to enable/disable credit-watchdog.

The OC testcases use SAI-thrift model to achieve this. This implementation installs the SAI-thrift package on the PTF container and imports this package in the testcases. The container acts like a client and DUT as server and SAI-thrift calls are made to execute BCM commands.

Options:

Option#1 does not require any modification, but option#2 will require to identify existing SAI version and choose way to enable/disable credit-watchdog based on that.

Results you see

The existing Broadcom shell CLI commands fail post SAI 11.x version.

Results you expected to see

Find a way to enable/disable credit-watchdog for SAI 11.x versions.

@sdszhang , @rawal01 @vmittal-msft

Is it platform specific

generic

Relevant log output

No response

Output of show version

No response

Attach files (if any)

No response

vmittal-msft commented 1 month ago

@amitpawar12 let us know if this works for you.

amitpawar12 commented 1 month ago

@vmittal-msft - I can try this on 2405/master testbed with SAI11.x or greater. However, action item during the meeting was to check if Broadcom internal register CLIs can be part of sonic-mgmt tests or not.

Thanks,

amitpawar12 commented 1 month ago

@saksarav-nokia

ysmanman commented 1 month ago

Created case CS00012371788 to check if BRCM is okay to use their diag cmd directly in sonic-mgmt code.

ysmanman commented 1 month ago

Created case CS00012371788 to check if BRCM is okay to use their diag cmd directly in sonic-mgmt code.

@vmittal-msft @amitpawar12 BRCM don't want to expose their register operation in public code :(

ysmanman commented 1 month ago

Created CSP CS00012374585 for recommendation from BRCM.