search

sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
196 stars 723 forks source link

[Bug]: monit/test_monit_status::test_monit_reporting_message fails because it is not multi-asic aware (lldp) #14968

Open vperumal opened 2 weeks ago

vperumal commented 2 weeks ago

Issue Description

Test is failing because it is trying to stop lldp container but on a multi-asic platform it should be stopping lldp0, lldp1, etc

    if (res.is_failed or 'exception' in res) and not module_ignore_errors:
      raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)

E tests.common.errors.RunAnsibleModuleFail: run module command failed, Ansible Results => E {"changed": true, "cmd": ["docker", "exec", "lldp", "supervisorctl", "stop", "lldpmgrd"], "delta": "0:00:00.015900", "end": "2024-10-07 05:42:34.683398", "failed": true, "msg": "non-zero return code", "rc": 1, "start": "2024-10-07 05:42:34.667498", "stderr": "Error response from daemon: No such container: lldp", "stderr_lines": ["Error response from daemon: No such container: lldp"], "stdout": "", "stdout_lines": []}

complex_args = {} filename = '/data/tests/common/devices/multi_asic.py' function_name = '_run_on_asics' index = 0 line_number = 134 lines = [' return getattr(self.sonichost, self.multi_asic_attr)(*module_args, **complex_args)\n'] module_args = ['docker exec lldp supervisorctl stop lldpmgrd'] module_async = False module_ignore_errors = False previous_frame = <frame at 0x7f4bce1b0230, file '/data/tests/common/devices/multi_asic.py', line 134, code _run_on_asics> res = {'failed': True, 'changed': True, 'stdout': '', 'stderr': 'Error response from daemon: No such container: lldp', 'rc':..., 'stdout_lines': [], 'stderr_lines': ['Error response from daemon: No such container: lldp'], '_ansible_no_log': None} self = verbose = True

Results you see

Test case uses the right containers for multi-asic platforms

Results you expected to see

Expecting to stop the right container

Is it platform specific

generic

Relevant log output

No response

Output of show version

No response

Attach files (if any)

No response

vperumal commented 2 weeks ago

FYI @abdosi @yejianquan

vperumal commented 2 weeks ago

https://github.com/sonic-net/sonic-mgmt/pull/13579 merged into master but not into 202405 branch - causing failures in 202405