sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
200 stars 732 forks source link

Add GNMI ZMQ test case, verify APPL_DB after GNMI set data. #15668

Open liuh-80 opened 1 week ago

liuh-80 commented 1 week ago

Add GNMI ZMQ test case, verify APPL_DB after GNMI set data.

Why I did it

Verify GNMI service will write data to APPL_DB.

Work item tracking

How I did it

Verify GNMI service will write data to APPL_DB.

How to verify it

Pass all test case.

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Add GNMI ZMQ test case, verify APPL_DB after GNMI set data.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

mssonicbld commented 1 week ago

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/gnmi/test_gnmi_zmq.py:5:1: F401 '.helper.gnmi_capabilities' imported but unused
tests/gnmi/test_gnmi_zmq.py:5:1: F401 '.helper.add_gnmi_client_common_name' imported but unused
tests/gnmi/test_gnmi_zmq.py:5:1: F401 '.helper.del_gnmi_client_common_name' imported but unused
tests/gnmi/test_gnmi_zmq.py:64:21: E127 continuation line over-indented for visual indent
tests/gnmi/test_gnmi_zmq.py:65:21: E127 continuation line over-indented for visual indent
tests/gnmi/test_gnmi_zmq.py:66:21: E127 continuation line over-indented for visual indent

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
  2. Ensure that the pre-commit package is installed:
    sudo pip install pre-commit
  3. Go to repository root folder
  4. Install the pre-commit hooks:
    pre-commit install
  5. Use pre-commit to check staged file:
    pre-commit
  6. Alternatively, you can check committed files using:
    pre-commit run --from-ref <commit_id> --to-ref <commit_id>
mssonicbld commented 1 week ago

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/zmq/test_gnmi_zmq.py:67:1: F811 redefinition of unused 'gnmi_set' from line 6
tests/zmq/test_gnmi_zmq.py:67:1: E303 too many blank lines (3)
tests/zmq/test_gnmi_zmq.py:110:21: E127 continuation line over-indented for visual indent
tests/zmq/test_gnmi_zmq.py:111:21: E127 continuation line over-indented for visual indent
tests/zmq/test_gnmi_zmq.py:112:21: E127 continuation line over-indented for visual indent

flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
  2. Ensure that the pre-commit package is installed:
    sudo pip install pre-commit
  3. Go to repository root folder
  4. Install the pre-commit hooks:
    pre-commit install
  5. Use pre-commit to check staged file:
    pre-commit
  6. Alternatively, you can check committed files using:
    pre-commit run --from-ref <commit_id> --to-ref <commit_id>