sonic-net / sonic-mgmt

Configuration management examples for SONiC
Other
200 stars 732 forks source link

Revert macsec commmit b5348ce #15685

Open augusdn opened 1 week ago

augusdn commented 1 week ago

Currently, change introduced in commit b5348ce is causing macsec test to fail. This commit reverts the changes introduced in commit b5348ce.

Description of PR

Summary: Currently, change introduced in commit b5348ce is causing macsec test to fail. This commit reverts the changes introduced in commit b5348ce.

On Cisco 8800, commit resulted in 2/10 pass ratio, while reverting the commit resulted in 12/16(had to run 4 consecutive times to check flaky tests), resulting in much higher passing rate.

Also the main reason for the reverting commit is that Cisco 8800 device is experiencing Port channel issue, where the status of Port channel on uplink LC remains Down after deploying mini-graph. While one PC comes back up, after initial macsec profile exchange, other remains down, and this will cause issue with sanity checks and bgp tests.

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation