The value of modular_chassis if string, not a bool, should not take it as bool - Githubissues

sonic-net / sonic-mgmt

Configuration management examples for SONiC

Other

200 stars 731 forks source link

The value of modular_chassis if string, not a bool, should not take it as bool #15693

Closed nhe-NV closed 4 days ago

nhe-NV commented 4 days ago

The value of modular_chassis if string, not a bool, should not take it as bool

Description of PR

Summary: Fixes # (issue)

Type of change

[x] Bug fix
[ ] Testbed and Framework(new/improvement)
[ ] Test case(new/improvement)

Back port request

[ ] 202012
[ ] 202205
[ ] 202305
[ ] 202311
[x] 202405

Approach

What is the motivation for this PR?

Fix the issue introduced by https://github.com/sonic-net/sonic-mgmt/pull/14368

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

yejianquan commented 4 days ago

After #14318 The modular_chassis is real bool rather that bool-values string, Please confirm again whether the value is bool or string?

@nhe-NV

nhe-NV commented 4 days ago

After #14318 The modular_chassis is real bool rather that bool-values string, Please confirm again whether the value is bool or string?

@nhe-NV

Thanks, I see