The test _bgp_traffic_shift::test_TSA_B_C_with_noneighbors doing restart to BGP process in finally step.
After that only the BGP docker is checked. No neighbors check.
The test itself passed, but if after it run another BGP test, for example _test_bgp_allowlist or _bgp_traffic_shift::testTSA, it will fail with error message:
_bgp_traffic_shift::testTSA:
pytest_assert(not res['failed'], "Failed to retrieve routes from VM {}".format(hostname))
E Failed: Failed to retrieve routes from VM ARISTA11T0
_test_bgp_allowlist:
'Unexpected routes on neighbors, failed_results={}'.format(json.dumps(failed_results, indent=2)))
E Failed: Unexpected routes on neighbors, failed_results={
E "ARISTA03T2": [
E {
E "reasons": [
E "Route 172.16.30.0/24 not found on ARISTA03T2"
E ],
E "failed": true,
E "prefix": "172.16.30.0/24"
E },
E {
E "reasons": [
E "Route 2000:172:16:50::/64 not found on ARISTA03T2"
E ],
E "failed": true,
E "prefix": "2000:172:16:50::/64"
E },
E .........
The easy way to fix it is to add checker _verify_all_routes_announce_toneighs for ipv4 and ipv6 at the end of test _bgp_traffic_shift::test_TSA_B_C_with_noneighbors , but it will take many time ~15 minutes for t1-lag topology. Need to add a more faster way to do it. In my debug tries I got, that the time of routes bring up on neighbors is ~3-4 minutes.
Steps to reproduce the issue:
run test test _bgp_traffic_shift::test_TSA_B_C_with_noneighbors on t1-lag topology
run test _bgp_traffic_shift::testTSA or _test_bgp_allowlist
Describe the results you received:
The second test always fails due to the fact that on neighbors not all routes are learned yet.
Describe the results you expected:
the tests can passed without dependency of execution order
Description
The test _bgp_traffic_shift::test_TSA_B_C_with_noneighbors doing restart to BGP process in finally step. After that only the BGP docker is checked. No neighbors check.
The test itself passed, but if after it run another BGP test, for example _test_bgp_allowlist or _bgp_traffic_shift::testTSA, it will fail with error message:
_bgp_traffic_shift::testTSA:
_test_bgp_allowlist:
The easy way to fix it is to add checker _verify_all_routes_announce_toneighs for ipv4 and ipv6 at the end of test _bgp_traffic_shift::test_TSA_B_C_with_noneighbors , but it will take many time ~15 minutes for t1-lag topology. Need to add a more faster way to do it. In my debug tries I got, that the time of routes bring up on neighbors is ~3-4 minutes.
Steps to reproduce the issue:
Describe the results you received: The second test always fails due to the fact that on neighbors not all routes are learned yet.
Describe the results you expected: the tests can passed without dependency of execution order
Additional information you deem important: