search

sonic-net / sonic-platform-daemons

Platform module daemons for SONiC
Other
23 stars 150 forks source link

On config interface shutdown, xcvrd to not reset CMIS state #258

Open shyam77git opened 2 years ago

shyam77git commented 2 years ago

While reviewing CMIS PR changeset - https://github.com/Azure/sonic-platform-daemons/pull/254/ , found following issue: Discussed with @prgeor and following is to be done (corrected/enhanced):

Issue: Why the cmis state is reseted when config-interface shutdown is configured. It supposed to avoid app_code reprogramming during this state. @jaganbal-a updated: As mentioned in the PR comment, We can have new state as CMIS_STATE_HOST_READY and this to be set under “elif state == self.CMIS_STATE_DP_DEINIT:” and self.CMIS_STATE_AP_CONF will be set only after the host_tx_ready is turned true. This will prevent moving state from DP_DEINIT to AP_CONF by default.

shyam77git commented 2 years ago

@jaganbal-a , @prgeor

prgeor commented 2 years ago

this is fixed in latest commit https://github.com/Azure/sonic-platform-daemons/pull/254 ...please check.