search

sonic-net / sonic-platform-daemons

Platform module daemons for SONiC
Other
23 stars 152 forks source link

Add Port SI Configuration Per Speed #400

Closed tshalvi closed 10 months ago

tshalvi commented 1 year ago

Description I have updated the lookup in media_settings.json. With the updated parser, media_settings.json now supports different SI values for various lane speeds. Previously, get_media_settings_key() returned two types of keys: vendor_key and media_key. With these code changes, three keys are now returned: vendor_key, media_key, and lane_speed_key. The parser, implemented in get_media_settings_value(), intelligently utilizes the lane_speed_key only for JSON files that support per-speed port SI values. In cases where the JSON does not support this feature, the parser's functionality remains unchanged.

Motivation and Context To achieve optimal configuration of their SerDes, some vendors wish to have the option to configure SerDes SI based on lane speeds. Therefore, we want to enhance the current ASIC configuration to provide support for configurations that take into account lane speed.

How Has This Been Tested? I was running the existing unit tests to test these changes, and updated them if needed. They all passed. Soon I will add new unit test to cover all my changes.

prgeor commented 11 months ago

@tshalvi please fix the code coverage

mihirpat1 commented 10 months ago

@yxieca - Can you please help in merging this to 202311? MSFT ADO - 26116605

prgeor commented 10 months ago

@tshalvi @liat-grozovik please see cherry pick conflict so may need separate pr for 202311

liushilongbuaa commented 10 months ago

@mihirpat1 , This PR is already in 202311 branch. mssonicbld can't cherry pick again. So, it is marked as Conflict.

keboliu commented 10 months ago

@yxieca @liushilongbuaa would you please remove the tag "request for 202311 branch" as it is already included in 202311?