search

sonic-net / sonic-platform-daemons

Platform module daemons for SONiC
Other
25 stars 159 forks source link

[xcvrd] Fix issue: logical_port_name is not defined #482

Closed Junchao-Mellanox closed 6 months ago

Junchao-Mellanox commented 7 months ago

Description

The code uses a variable named "logical_port_name", but that variable is not defined in the code context. I believe the code was copied from some where without modifying the variable name. The PR is to fix it.

Motivation and Context

Fix issue: logical_port_name is not defined

How Has This Been Tested?

Manual test

Additional Information (Optional)

prgeor commented 7 months ago

@Junchao-Mellanox build is failing...

mihirpat1 commented 7 months ago

@Junchao-Mellanox Please help in fixing the code coverage check

Junchao-Mellanox commented 6 months ago

Hi @prgeor , UT added, could you please review?

yxieca commented 6 months ago

@Junchao-Mellanox @prgeor I don't have enough information from PR comment to understand the change and issue it is addressing. Please update the PR comments with more information. @prgeor do you agree to backport this change?

Junchao-Mellanox commented 6 months ago

Hi @yxieca , I added some description. Please kindly review again.

mssonicbld commented 6 months ago

Cherry-pick PR to 202311: https://github.com/sonic-net/sonic-platform-daemons/pull/488