search

sonic-net / sonic-platform-daemons

Platform module daemons for SONiC
Other
25 stars 159 forks source link

Fix for 'log_notifce()' typo in xcvrd.py #492

Closed tshalvi closed 5 months ago

tshalvi commented 6 months ago

This PR fixes the following issue: https://github.com/sonic-net/sonic-buildimage/issues/19116

Description

 Typo fix: log_notifce() --> log_notice()

Motivation and Context

PR https://github.com/sonic-net/sonic-platform-daemons/pull/459 introduces a typo "log_notifce". Check line: https://github.com/sonic-net/sonic-platform-daemons/blob/9ffce2036d53571bd23b4a630ac285039e383c4f/sonic-xcvrd/xcvrd/xcvrd.py#L1482.

It causes an exception in cmis task manager which results in port down:

May 27 20:38:17.489639 sonic ERR pmon#xcvrd: CMIS: Ethernet96: internal errors due to 'CmisManagerTask' object has no attribute 'log_notifce'

How Has This Been Tested?

Additional Information (Optional)

tshalvi commented 6 months ago

/azpw run

mssonicbld commented 6 months ago

/AzurePipelines run

azure-pipelines[bot] commented 6 months ago
Azure Pipelines successfully started running 1 pipeline(s).
tshalvi commented 5 months ago

The developer who introduced the typo has already raised a PR to fix it. Closing this PR.