sonic-net / sonic-platform-daemons

Platform module daemons for SONiC
Other
23 stars 152 forks source link

Don't process CMIS xcvrs on warm-reboot case #494

Closed bobbymcgonigle closed 4 months ago

bobbymcgonigle commented 4 months ago

Description

When warm-reboot happens xcvrd gets started it treats xcvrs as going through an insertion event. In the case of optics who on insertion event might need to be reprogrammed, it will force the TX off and disable them.

On warm-reboot, we don't want to do this - the xcvrs are already programmed correctly and it will impact dataplane traffic.

Motivation and Context

Interfaces with cmis optics in breakout configurations would stay down after warm-reboot cases in sonic-mgmt test runs.

How Has This Been Tested?

I tested this using a sonic-mgmt warm-reboot case where the optics would stay down and fail entire t0 runs. Those tests now pass and the interfaces stay up.

I also checked the flap counters on the peer for those interfaces - the link stayed up and did not flap - showing warm-reboot succeeded as expected.

Additional Information (Optional)

bobbymcgonigle commented 4 months ago

Looking into unit test issue

prgeor commented 4 months ago

@bobbymcgonigle I think we can clos this. This is already taken care. feel free to open otherwise.