sonic-net / sonic-platform-daemons

Platform module daemons for SONiC
Other
25 stars 159 forks source link

Take non-CMIS xcvrs out of lpmode in SFF Manager #565

Open peterbailey-arista opened 16 hours ago

peterbailey-arista commented 16 hours ago

Description

Fix non-CMIS transceivers in down state by bringing them out of low power mode in the SFF Manager Task. This is intended to work together with the change in https://github.com/sonic-net/sonic-buildimage/pull/20886.

Motivation and Context

Non-CMIS transceivers were not functioning correctly when put into Low Power mode. So XCVRD now brings them out of lpmode.

How Has This Been Tested?

Loaded an image containing this change alongside the change from https://github.com/sonic-net/sonic-buildimage/pull/20886 on an Arista chassis containing a Clearwater2 linecard. Verified that without this image some interfaces were in a down state but with the image all interfaces came up as expected.

Additional Information (Optional)

linux-foundation-easycla[bot] commented 16 hours ago

CLA Signed


The committers listed above are authorized under a signed CLA.

kenneth-arista commented 14 hours ago

@arlakshm @wenyiz2021 for awareness

kenneth-arista commented 9 hours ago

Yes, along with enabling the SFF manager in xcvrd per platform config ( https://github.com/sonic-net/sonic-buildimage/pull/20886).

On Thu, Nov 21, 2024 at 5:57 PM wenyiz2021 @.***> wrote:

do we only need this PR for the LP mode causing links down issue?

— Reply to this email directly, view it on GitHub https://github.com/sonic-net/sonic-platform-daemons/pull/565#issuecomment-2492713603, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWIHIW6M2AJXRJ3DQENRAQ32B2FO3AVCNFSM6AAAAABSHXSQQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJSG4YTGNRQGM . You are receiving this because you commented.Message ID: @.***>