search

sonic-net / sonic-platform-modules-dell

platform drivers for dell switches
Other
4 stars 12 forks source link

Add BCM sensor values. Remove BCM & CPU internal listing from PMC #36

Closed padmanarayana closed 5 years ago

padmanarayana commented 6 years ago
  1. The BCM & CPU Internal temperature strings are present only for S6100. I’ve marked both as “Unused” since the SMF does not retrieve these. Also, CPU Internal is not necessary from SMF since the coretemp-isa driver dumps it anyway. The entries are marked “unused” instead of being deleted to preserve formatting.
  2. BCM sensors are being retrieved for both S6100 & Z9100. Added a check to see if syncd is up before bcmcmd can be issued.
  3. Fixed a nit in Z9100 sensors that indicated it’s a S6100 (typo from another commit).
stcheng commented 6 years ago

my concern is that invoking bcmcmd is periodically is not that safe and the way of checking whether syncd process is running is a little bit fragile i will spend some more time to evaluate this approach further

lguohan commented 6 years ago

use

SAI_SWITCH_ATTR_MAX_TEMP in https://github.com/opencomputeproject/SAI/blob/master/inc/saiswitch.h

@padmanarayana , can you also add SAI_SWITCH_ATTR_CURRENT_TEMP