search

sonic-net / sonic-sairedis

SAI object interface to Redis database, as used in the SONiC project
Other
56 stars 270 forks source link

[submodule] Update SAI submodule to v1.13 #1285

Closed kcudnik closed 1 year ago

kcudnik commented 1 year ago

Add needed changes and new files required by new SAI version

kcudnik commented 1 year ago

O cherrypicked changes from https://github.com/sonic-net/sonic-sairedis/pull/1255 to compensate for unittests, since SAI headers changes tunnel conditions and unittsts mus be updated

kcudnik commented 1 year ago

buildswss amd64 seems to be not related to this change, since test crashes on neighbors, and this code don't touch neighbors at all, im making pure test on dummy commit just to see if it will compile https://github.com/sonic-net/sonic-sairedis/pull/1286, sinc at this PR the swss failed to compile 3 times on the same error

kcudnik commented 1 year ago

dummy build is passing, not sure how my change influences the unittests in swss, will try to investigate locally

kcudnik commented 1 year ago

@stepanblyschak can you point me what could be the reason this fails ?

PASS: tests_response_publisher
../../config/test-driver: line 109:  8929 Aborted                 (core dumped) "$@" > $log_file 2>&1

i saw you worked on this on swss repo https://github.com/sonic-net/sonic-swss/commit/4df5cab5bdc59f1ea5c96346d2cfaf4f7698bc43

and this fails, and i can't figure out direct correlation between my change and why this test fails, im just adding new api here

actually i noticed that "tests" are failing, should be "PASS: tests" but got core dumped

kcudnik commented 1 year ago

@theasianpianist can you help me with that ?

[----------] 14 tests from MuxRollbackTest
[ RUN      ] MuxRollbackTest.StandbyToActiveNeighborAlreadyExists
FAIL tests (exit status: 134)

not sure how my change is related to this test, you worked on that https://github.com/sonic-net/sonic-swss/commit/bc4062b12, but i don't see any correlation to my changes, i'm adding just new api support, nothing related to neighbor yet test somehow fail

kcudnik commented 1 year ago

swss failure related to newer SAI:

Sep  4 13:00:34 713a148e1b79 tests: :- addDecapTunnel: Create overlay loopback router interface oid:600000003
Sep  4 13:00:34 713a148e1b79 tests: :- meta_generic_validation_create: SAI_TUNNEL_TERM_TABLE_ENTRY_ATTR_SRC_IP:SAI_ATTR_VALUE_TYPE_IP_ADDRESS attribute is conditional and is mandatory but not passed in attr list
Sep  4 13:00:34 713a148e1b79 tests: :- addDecapTunnelTermEntries: Failed to create tunnel entry table for ip: 2.2.2.2
Sep  4 13:00:34 713a148e1b79 tests: :- handleSaiCreateStatus: Encountered failure in create operation, exiting orchagent, SAI API: SAI_API_TUNNEL, status: SAI_STATUS_MANDATORY_ATTRIBUTE_MISSING
Sep  4 13:00:34 713a148e1b79 tests: :- meta_unittests_allow_readonly_set_once: unittests are not enabled
Sep  4 13:00:34 713a148e1b79 tests: :- handleSaiFailure: Failed to take sai failure dump -1

because of https://github.com/sonic-net/sonic-sairedis/pull/1255, new attribute is required and metadata is catching this error

there is no way to solve that, one of the repos needs to be first checked in with failed state, then they both will pass, of course swss repo needs to be adapted to new SAI headers

kcudnik commented 1 year ago

needs this https://github.com/sonic-net/sonic-swss/pull/2894 to pass tests

kcudnik commented 1 year ago

test errors not related to PR, @prsunny can you take a look seems like flacky tests are failing

kcudnik commented 1 year ago

moved to another new PR