sonic-net / sonic-sairedis

SAI object interface to Redis database, as used in the SONiC project
Other
56 stars 270 forks source link

Add SAI Notification support for host_tx_ready #1307

Closed noaOrMlnx closed 11 months ago

noaOrMlnx commented 1 year ago

New PORT_HOST_TX_READY notification logic was added to sonic-sairedis and syncd in order to support host_tx_ready synchronization enhancements.

HLD: https://github.com/sonic-net/SONiC/pull/1453

noaOrMlnx commented 1 year ago

/azpw run Azure.sonic-sairedis

mssonicbld commented 1 year ago

/AzurePipelines run Azure.sonic-sairedis

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
Junchao-Mellanox commented 1 year ago

/azpw run Azure.sonic-sairedis

kcudnik commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
kcudnik commented 1 year ago

hey, you must update to latest master to fix notifications since SAI was updated, you can take a look here: https://github.com/sonic-net/sonic-sairedis/pull/1311/files

kcudnik commented 12 months ago

please fix whitespaces:

../vslib/Switch.cpp:                m_switchNotifications.on_port_host_tx_ready = 
ERROR: some files contain white spaces at the end of line, please fix
FAIL: checkwhitespace.sh
noaOrMlnx commented 12 months ago

Hi @kcudnik

I tried to remove all whitespaces, and there is no whitespace in the line stated in the UT. Can you please point me to the issue?

kcudnik commented 12 months ago

Please spend time to read compiler ero Rorschach in AZ pipeline:

Checkig for white spaces ...
../saiplayer/SaiPlayer.cpp:    
../saiplayer/SaiPlayer.h:        
../vslib/Switch.cpp:                m_switchNotifications.on_port_host_tx_ready = 
ERROR: some files contain white spaces at the end of line, please fix
FAIL: checkwhitespace.sh